"Viewing Party," - Shelby Faulconer, Ada C17 #119

pickled-bot · 2022-03-28T16:20:10Z

…ss. Adjusted play_tester file by working through problems in the party file. All graveyard code lives in the play_tester. All test wave files were adjusted to comment out the skips.

kelsey-steven-ada · 2022-03-31T03:42:50Z

tests/test_wave_01.py

    # *******************************************************************************************
    # ****** Add assertions here to test that the correct movie was added to "watched" **********
    # *******************************************************************************************


There's a few tests with a comment similar to this where we would like you to add your own assertions. What could we assert about the data for a specific movie if we wanted to confirm that the movie in the "watched" list holds the information that we expect it to?

kelsey-steven-ada · 2022-03-31T03:43:20Z

tests/test_wave_01.py

    # *******************************************************************************************
    # ****** Add assertions here to test that the correct movie was added to "watched" **********
    # *******************************************************************************************


Same question as for the test above, what could we assert about the three pieces of data a movie holds to confirm it is the movie we expect it to be?

kelsey-steven-ada · 2022-03-31T03:44:51Z

tests/test_wave_03.py

@@ -59,7 +59,7 @@ def test_friends_unique_movies_not_duplicated():
    # ****** Add assertions here to test that the correct movies are in friends_unique_movies **********


The assert that came with the test lets us know how many movies to expect in the list friends_unique_movies, what can we assert to make sure the data each movie holds is correct?

kelsey-steven-ada · 2022-03-31T03:46:05Z

tests/test_wave_05.py

@@ -57,7 +57,7 @@ def test_new_genre_rec_from_empty_friends():
    # ****** Complete the Act and Assert Portions of theis tests **********


For this test we need to complete both the act & assert steps. What would that look like?

kelsey-steven-ada · 2022-03-31T03:49:29Z

viewing_party/party.py

+# If any of the three variables is missing, return None
+
+from decimal import DivisionByZero
+from tests.test_constants import USER_DATA_2


We generally don't want production code to import or otherwise be dependent on test data. It doesn't look like this import is being used now, so we would want to clean it up so our program doesn't bring in resources it doesn't need.

kelsey-steven-ada · 2022-03-31T03:51:21Z

viewing_party/party.py

 def create_movie(title, genre, rating):
-    pass
+
+    if not title or not genre or not rating:


Nice use of the truthy/falsyness of the parameters for checking invalid input!

kelsey-steven-ada · 2022-03-31T03:53:11Z

viewing_party/party.py

+
+    if not title or not genre or not rating:
+        return None
+    else: 


There's nothing wrong with it, but we don't need to put this code in an else-block as long as it comes after the if-statement that checks for invalid data.

kelsey-steven-ada · 2022-03-31T03:56:35Z

viewing_party/party.py

+    for movies in user_data["watchlist"]:
+        if movies["title"] == title: 
+            user_data["watchlist"].remove(movies)
+            user_data["watched"].append(movies)


Right now we continue iterating over the watchlist after we perform our swap. In most cases this isn't a big deal, but say we were dealing with lists of thousands of movies. We would probably want to exit the loop right after we perform the operation we want, or we'll continuing to loop over potentially hundreds of more titles! How would we be able to halt execution once we performed our swap?

Another consideration: we are removing a value from a list we are actively iterating over, so after the first removal, we skip a value because the way iterators work (recall our discussion on the "danger zone" from the roundtable on "Iterating over Data"). Given the data for our tests, we know this isn't a concern for this application, but what if we were working with data that had duplicate titles?

kelsey-steven-ada · 2022-03-31T03:59:24Z

viewing_party/party.py

+# {   'watched': [   {   'genre': 'Fantasy',
+#                        'rating': 4.8,
+#                        'title': 'The Lord of the Functions: The Fellowship of '
+#                                 'the Function'},
+#                    {   'genre': 'Fantasy',
+#                        'rating': 4.0,
+#                        'title': 'The Lord of the Functions: The Two '
+#                                 'Parameters'},
+#                    {   'genre': 'Fantasy',
+#                        'rating': 4.0,
+#                        'title': 'The Lord of the Functions: The Return of the '
+#                                 'Value'},
+#                    {   'genre': 'Action',
+#                        'rating': 2.2,
+#                        'title': 'The JavaScript and the React'},
+#                    {'genre': 'Intrigue', 'rating': 2.0, 'title': 'Recursion'},
+#                    {   'genre': 'Intrigue',
+#                        'rating': 4.5,
+#                        'title': 'Instructor Student TA Manager'}]}


We generally want to remove coding aids like this example data as part of our refactor and clean up steps.

kelsey-steven-ada · 2022-03-31T04:04:48Z

viewing_party/party.py

+    watched_movies = user_data["watched"] ## array of dictionaries
+    total_rating = []
+    counter = 0 
+## for a dictionary in the list of movies


As part of cleaning up code at the end, I recommend either removing the comments like this and the one above on line 93, or rewriting them to describe what the code is doing conceptually. For example, we might change this one to something like "loop over dictionaries representing movies to sum rating"

kelsey-steven-ada · 2022-03-31T04:08:20Z

viewing_party/party.py

+    counter = 0 
+## for a dictionary in the list of movies
+    for movie_data in watched_movies:
+        v = movie_data["rating"]


We should avoid single letter variables names in favor of ones that describe what our data represents. Some names we could use that would help readability might be "movie_rating", "rating", or "current_rating".

kelsey-steven-ada · 2022-03-31T04:11:51Z

viewing_party/party.py

+    for movie_data in watched_movies:
+        v = movie_data["rating"]
+        total_rating.append(v)
+    if len(total_rating) == 0:


The preferred syntax for checking if a list is empty in python is to use the truthy/falsyness of the list (just like the input validation for create_movie above!)

if not total_rating:

kelsey-steven-ada · 2022-03-31T04:21:48Z

viewing_party/party.py

+## def function to track most watched genre
+## COUNT of times genre appears
+## If there is no amount, return error message
+# '''
+# input: take in the parameter 'user_data' : a nested dictionary 
+# with a VALUE 'watched' list of movie dictionaries
+# each movie has the KEY "genre"
+# >> this VALUE represents user's list of watched movies
+# >> each watched movie contains a genre
+# >>>> the VALUES of  KEY "genre" is a string
+# create a COUNTER to count which "genre" occurs most often
+# If the value of "watched" is empty, return None

+# output: The string of the genre that is most frequently watched,
+# if value of watched is an empty list could try ... else none

+# '''


If we want to keep detailed info for a function like this, we should use docstring syntax, by moving it inside the function right under the function name and removing the leading # characters. I would also strongly consider rewriting or condensing portions so that it reads more like spoken language. Here's more info on docstrings in case it's helpful: https://peps.python.org/pep-0257/

kelsey-steven-ada · 2022-03-31T04:25:42Z

viewing_party/party.py

+    popular_genre = []
+    count = 0
+
+    if watched_movies == []:


Similar to line 100, the preferred way to check if our watched_movies list is empty would be if not watched_movies:

kelsey-steven-ada · 2022-03-31T04:30:43Z

viewing_party/party.py

+    for movie_data in watched_movies: 
+        popular_genre.append(movie_data["genre"])
+    for movie_data in watched_movies: 
+        if count < popular_genre.count(movie_data["genre"]):


Nice use of count! What would this implementation look like without the count function?

kelsey-steven-ada · 2022-03-31T04:44:52Z

viewing_party/party.py

+    for movie_data in watched_movies: 
+        if count < popular_genre.count(movie_data["genre"]):
+            count = popular_genre.count(movie_data["genre"])
+    return popular_genre[0]


Here we are returning the first item in popular_genre, which may or may not be the user's most watched genre. We have a count variable that finds the highest count of any of the genres, if we declared another variable before the loop that would hold the most popular genre we could do something like:

most_popular_genre = "" . . . for movie_data in watched_movies: genre_count = popular_genre.count(movie_data["genre"] if count < genre_count): count = genre_count most_popular_genre = movie_data["genre"] return most_popular_genre

kelsey-steven-ada · 2022-03-31T04:58:52Z

viewing_party/party.py

+
+def get_most_watched_genre(user_data):
+    watched_movies = user_data["watched"]
+    popular_genre = []


I think it would be a good exercise to look at how this could be implemented differently with a dictionary instead of a list. What if we built up a mapping using genres for keys with their counts for values?

kelsey-steven-ada · 2022-03-31T05:03:14Z

viewing_party/party.py

+    dictionary_friend_movies = []
+    unique_user_movies = [] 
+
+    for movie_watched in friends_list:


The way this is named, my initial instinct was that movie_watched would be a specific movie's dictionary. Since this is a dictionary holding a list of watched items, something plural like "friend_dict" or "movies_dict" would be a little more descriptive.

kelsey-steven-ada · 2022-03-31T05:07:18Z

viewing_party/party.py

+    watched_movies = user_data["watched"]
+    friends_list = user_data["friends"]
+    user_watched = []
+    dictionary_friend_movies = []


Since this structure is a list, it's a little misleading to name it starting with dictionary_ and might cause confusion for people trying to reason about what the variable holds. Since this list will hold all of the friends' movies, I think something like friends_movies would be descriptive enough.

kelsey-steven-ada · 2022-03-31T05:09:25Z

viewing_party/party.py

+    unique_user_movies = [] 
+
+    for movie_watched in friends_list:
+        for movie in movie_watched["watched"]:


Nice choice to flatten the friends' movies into a single list you could check against!

kelsey-steven-ada · 2022-03-31T05:12:14Z

viewing_party/party.py

+        for movie in movie_watched["watched"]:
+            dictionary_friend_movies.append(movie)
+    for movie in watched_movies:
+        user_watched.append(movie)


We are appending values to user_watched here, but I don't see the list being used afterword. If they aren't being used, we should remove this line and the user_watched variable.

kelsey-steven-ada · 2022-03-31T05:21:19Z

viewing_party/party.py

+    unique_friend_movies = [] 
+    unique_unique = []
+
+    for movie_watched in friends_list: # {} in [{}]


The comment on line 150 applies here as well.

kelsey-steven-ada · 2022-03-31T05:23:06Z

viewing_party/party.py

+
+    for movie_watched in friends_list: # {} in [{}]
+        for movie in movie_watched["watched"]: 
+            if movie not in unique_friend_movies:


Since set data structures cannot contain duplicates, how could we use them here where we want to find unique items?

We could copy the movie_watched["watched"] data into a set and check to see if the set has changed length.

kelsey-steven-ada · 2022-03-31T05:27:50Z

viewing_party/party.py

+        for movie in movie_watched["watched"]: 
+            if movie not in unique_friend_movies:
+                unique_friend_movies.append(movie)
+                if movie in unique_friend_movies and movie not in watched_movies:


Thinking about sets more, say our unique_friend_movies and watched_movies were sets. We could then use set operations to find the difference - all the items in set a (unique_friend_movies) that are not in set b (watched_movies).

kelsey-steven-ada · 2022-03-31T05:29:31Z

viewing_party/party.py

+def get_available_recs(user_data):
+    movie_rec = []
+    watched_movies = user_data["watched"]
+    unique_movie_friends = get_friends_unique_watched(user_data)


🎉 Love to see code reuse! 🎉

kelsey-steven-ada · 2022-03-31T05:30:28Z

viewing_party/party.py

+    for movie in unique_movie_friends:
+        if movie["host"] in user_subscriptions and movie not in watched_movies:
+            movie_rec.append(movie)
+    return movie_rec


Nice & compact solution!

kelsey-steven-ada · 2022-03-31T05:31:34Z

viewing_party/party.py

+    popular_genre = get_most_watched_genre(user_data)
+    unique_movie_friends = get_friends_unique_watched(user_data)


Yesss, reusing those functions!

kelsey-steven-ada · 2022-03-31T05:33:57Z

viewing_party/party.py

+    for movie in friends_list:
+        for watched_movie in movie["watched"]:
+           friend_watched.append(watched_movie)


We perform this task of condensing all the friend's movies into a single list in a few functions. This makes it a prime candidate to be pulled out to its own function for reuse!

kelsey-steven-ada · 2022-03-31T05:38:33Z

Congrats on completing your first project in Unit 1! I've added some suggestions and a couple questions, let me know if there's anything I can clarify.

…ithin the function get_most_watched_genre().

adjusted viewing_party by writing and running functions until they pa…

71bb211

…ss. Adjusted play_tester file by working through problems in the party file. All graveyard code lives in the play_tester. All test wave files were adjusted to comment out the skips.

kelsey-steven-ada reviewed Mar 31, 2022

View reviewed changes

pickled-bot added 6 commits April 11, 2022 16:20

Added assert statements to test_wave_01.py

ee8057a

Added assert statements to test_wave_03.py

adb3b79

Added act and assert statements to test_wave_05.py

9799587

Added some old code to the play_tester.

50610f6

commented out code that wasn't being used.

951ce5f

Refactored party.py to clean up the code and account for edge cases w…

e273087

…ithin the function get_most_watched_genre().

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Viewing Party," - Shelby Faulconer, Ada C17 #119

"Viewing Party," - Shelby Faulconer, Ada C17 #119

pickled-bot commented Mar 28, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022 •

edited

Loading

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

pickled-bot Apr 11, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada Mar 31, 2022

kelsey-steven-ada commented Mar 31, 2022

		@@ -59,7 +59,7 @@ def test_friends_unique_movies_not_duplicated():
		# **** Add assertions here to test that the correct movies are in friends_unique_movies ********

		@@ -57,7 +57,7 @@ def test_new_genre_rec_from_empty_friends():
		# **** Complete the Act and Assert Portions of theis tests ********

		popular_genre = get_most_watched_genre(user_data)
		unique_movie_friends = get_friends_unique_watched(user_data)

"Viewing Party," - Shelby Faulconer, Ada C17 #119

Are you sure you want to change the base?

"Viewing Party," - Shelby Faulconer, Ada C17 #119

Conversation

pickled-bot commented Mar 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kelsey-steven-ada Mar 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kelsey-steven-ada commented Mar 31, 2022

kelsey-steven-ada Mar 31, 2022 •

edited

Loading