-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap_meet_Daria_Iakymenko_C17(Whales) #92
base: master
Are you sure you want to change the base?
Changes from all commits
e0065b5
67b8797
199a1c9
546f6dd
77e69f3
3c1b332
bd98457
31bbf40
8121f0e
8a27d31
46ccad2
0cccb84
382415e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,9 @@ | ||
class Clothing: | ||
pass | ||
from swap_meet.item import Item | ||
|
||
class Clothing(Item): | ||
|
||
def __init__(self, condition = 0, age = 0): | ||
super().__init__("Clothing", condition, age) | ||
|
||
def __str__ (self): | ||
return "The finest clothing you could wear." |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,9 @@ | ||
class Decor: | ||
pass | ||
from swap_meet.item import Item | ||
|
||
class Decor(Item): | ||
def __init__(self, condition = 0, age = 0): | ||
super().__init__("Decor", condition, age) | ||
|
||
def __str__ (self): | ||
return "Something to decorate your space." | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,9 @@ | ||
class Electronics: | ||
pass | ||
from swap_meet.item import Item | ||
|
||
class Electronics(Item): | ||
def __init__(self, condition = 0, age = 0): | ||
super().__init__("Electronics", condition, age) | ||
|
||
def __str__ (self): | ||
return "A gadget full of buttons and secrets." | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,23 @@ | ||
class Item: | ||
pass | ||
def __init__(self,category = "", condition = 0, age = 0): | ||
self.category = category | ||
self.condition = condition | ||
self.age = age | ||
|
||
def __str__ (self): | ||
return "Hello World!" | ||
|
||
def condition_description(self): | ||
if self.condition == 0: | ||
return "Poor" | ||
elif self.condition == 1: | ||
return "Could be better" | ||
elif self.condition == 2: | ||
return "So so" | ||
elif self.condition == 3: | ||
return "Quite good" | ||
elif self.condition == 4: | ||
return "Good" | ||
else: | ||
return "Excellent" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,73 @@ | ||
class Vendor: | ||
pass | ||
def __init__(self, inventory= None): | ||
if not inventory: | ||
inventory = [] | ||
self.inventory = inventory | ||
|
||
|
||
def add(self, item): | ||
self.inventory.append(item) | ||
return item | ||
|
||
|
||
def remove(self, item): | ||
if item in self.inventory: | ||
self.inventory.remove(item) | ||
return item | ||
else: | ||
return False | ||
|
||
|
||
def get_by_category(self, category): | ||
list_items = [] | ||
for item in self.inventory: | ||
if item.category == category: | ||
list_items.append(item) | ||
return list_items | ||
|
||
|
||
def swap_items(self, vendor, my_item, their_item): | ||
if my_item not in self.inventory or their_item not in vendor.inventory: | ||
return False | ||
other_index = vendor.inventory.index(their_item) | ||
self_index = self.inventory.index(my_item) | ||
temp_item = my_item | ||
self.inventory[self_index] = their_item | ||
vendor.inventory[other_index] = temp_item | ||
Comment on lines
+32
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very nice implementation to literally swap by the items' index values! Another approach is using .append() and .remove() but your implementation is just as good! |
||
return True | ||
|
||
|
||
def swap_first_item(self, vendor): | ||
if self.inventory and vendor.inventory: | ||
return self.swap_items(vendor, self.inventory[0], vendor.inventory[0]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very nice! Takes advantage of .swap_items() return value and guard clause will prevent an IndexError 👍🏻 Love it! |
||
|
||
|
||
def get_best_by_category(self, category): | ||
condition = 0 | ||
item_to_return = None | ||
for item in self.inventory: | ||
if item.category == category: | ||
if condition < item.condition: | ||
condition = item.condition | ||
item_to_return = item | ||
return item_to_return | ||
|
||
|
||
def swap_best_by_category(self, other, my_priority, their_priority): | ||
vendor_best_item = self.get_best_by_category(their_priority) | ||
other_best_item = other.get_best_by_category(my_priority) | ||
return self.swap_items(other, vendor_best_item, other_best_item) | ||
Comment on lines
+56
to
+59
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice use of helper functions to make this concise! |
||
|
||
|
||
def swap_by_newest(self, other, category): | ||
'''The function takes another vendor as "other" | ||
and a category of items we'd like to exchange as parameters. | ||
First, it makes a list of all items in this category, | ||
then picks up the newest item in each of the lists and swaps them. | ||
Returns True if the swap was made. | ||
''' | ||
my_category_list = self.get_by_category(category) | ||
other_category_list = other.get_by_category(category) | ||
my_newest_item = min(my_category_list, key=lambda x: x.age) | ||
other_newest_item = min(other_category_list, key=lambda x: x.age) | ||
Comment on lines
+71
to
+72
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wonderful use of min() and lambda! |
||
return self.swap_items(other, my_newest_item, other_newest_item) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,12 +2,12 @@ | |
import pytest | ||
from swap_meet.vendor import Vendor | ||
|
||
@pytest.mark.skip | ||
#@pytest.mark.skip | ||
def test_vendor_has_inventory(): | ||
vendor = Vendor() | ||
assert len(vendor.inventory) == 0 | ||
|
||
@pytest.mark.skip | ||
#@pytest.mark.skip | ||
def test_vendor_takes_optional_inventory(): | ||
inventory = ["a", "b", "c"] | ||
vendor = Vendor(inventory=inventory) | ||
|
@@ -16,7 +16,7 @@ def test_vendor_takes_optional_inventory(): | |
assert "b" in vendor.inventory | ||
assert "c" in vendor.inventory | ||
|
||
@pytest.mark.skip | ||
#@pytest.mark.skip | ||
def test_adding_to_inventory(): | ||
vendor = Vendor() | ||
item = "new item" | ||
|
@@ -27,7 +27,7 @@ def test_adding_to_inventory(): | |
assert item in vendor.inventory | ||
assert result == item | ||
|
||
@pytest.mark.skip | ||
#@pytest.mark.skip | ||
def test_removing_from_inventory_returns_item(): | ||
item = "item to remove" | ||
vendor = Vendor( | ||
|
@@ -40,7 +40,7 @@ def test_removing_from_inventory_returns_item(): | |
assert item not in vendor.inventory | ||
assert result == item | ||
|
||
@pytest.mark.skip | ||
#@pytest.mark.skip | ||
def test_removing_not_found_is_false(): | ||
item = "item to remove" | ||
vendor = Vendor( | ||
|
@@ -49,7 +49,4 @@ def test_removing_not_found_is_false(): | |
|
||
result = vendor.remove(item) | ||
|
||
raise Exception("Complete this test according to comments below.") | ||
# ********************************************************************* | ||
# ****** Complete Assert Portion of this test ********** | ||
# ********************************************************************* | ||
assert result == False #added assert | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍🏻 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,12 +2,12 @@ | |
from swap_meet.vendor import Vendor | ||
from swap_meet.item import Item | ||
|
||
@pytest.mark.skip | ||
#@pytest.mark.skip | ||
def test_items_have_blank_default_category(): | ||
item = Item() | ||
assert item.category == "" | ||
|
||
@pytest.mark.skip | ||
#@pytest.mark.skip | ||
def test_get_items_by_category(): | ||
item_a = Item(category="clothing") | ||
item_b = Item(category="electronics") | ||
|
@@ -23,7 +23,7 @@ def test_get_items_by_category(): | |
assert item_c in items | ||
assert item_b not in items | ||
|
||
@pytest.mark.skip | ||
#pytest.mark.skip | ||
def test_get_no_matching_items_by_category(): | ||
item_a = Item(category="clothing") | ||
item_b = Item(category="clothing") | ||
|
@@ -33,8 +33,4 @@ def test_get_no_matching_items_by_category(): | |
) | ||
|
||
items = vendor.get_by_category("electronics") | ||
|
||
raise Exception("Complete this test according to comments below.") | ||
# ********************************************************************* | ||
# ****** Complete Assert Portion of this test ********** | ||
# ********************************************************************* | ||
assert items == [] #added assert | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Taking advantage of inheritance by using the parent class's constructor makes this concise!