-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C17 (Sea Turtles) - Shannon Bellemore #107
base: master
Are you sure you want to change the base?
Conversation
</head> | ||
<body> | ||
|
||
<header> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page is clean, semantic and readable. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great job Shannon. I like the organization of your files, the layout of your pages, and the colors. I left a few comments on some things you could change. Let me know if you have any questions.
<section class="home"> | ||
<h2>Featured Project</h2> | ||
<a href="https://github.com/eggoweggo/task-list-api"> | ||
<img src="/images/task-list.png" alt="Cartoon cat sweeping with broom"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great use of the alt attribute with descriptive text
<main> | ||
<section class="portfolio"> | ||
<h2>Personal Portfolio Project</h2> | ||
<a href="https://github.com/eggoweggo/personal-portfolio-site"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could add the target attribute to your links and it will open them in a new tab. This keeps the user on your page and be able to access other content
an example is here https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_a_target
color: #3e3e3e; | ||
font-weight: 300; | ||
background-color: #A3AC9C | ||
/* background: url('../images/background.png') */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove unused code
</nav> | ||
</header> | ||
<main> | ||
<p>My name is Shannon Bellemore and I am currently a software developer student at Ada Developers Academy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add some padding around this text. It was hard to read the beginning of it on safari.
list-style-type: none; | ||
} | ||
|
||
a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make it more user friendly I would add an effect to your links so folks know its a link. Maybe when you hover the mouse could change to a pointer or the text could change colors.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions