Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C17 (Sea Turtles) - Shannon Bellemore #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eggoweggo
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I had a section that did not have a h1, h6, etc. so I had to change it so it would be valid. I also forgot I had links in that weren't being used.
Why is it important to consider and use semantic HTML? It is important so that if someone else is reading your code or you got back to it, it is readable and makes sense.
How did you decide to structure your CSS? I followed the order of the requirements.
What was the most challenging piece of this assignment? Getting things to space the way I wanted. I still have to tweak things as I learn more because it does not look the way I want to yet.
Describe one area that you gained more clarity on when completing this assignment I feel I just got an overall better understanding of HTML and CSS as I had to rush through it due to personal circumstances, so I will definitely be reviewing and practicing more so I can go back and update my portfolio for more of how I envisioned it.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
No

</head>
<body>

<header>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page is clean, semantic and readable. Good job!

Copy link

@tgoslee tgoslee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great job Shannon. I like the organization of your files, the layout of your pages, and the colors. I left a few comments on some things you could change. Let me know if you have any questions.

<section class="home">
<h2>Featured Project</h2>
<a href="https://github.com/eggoweggo/task-list-api">
<img src="/images/task-list.png" alt="Cartoon cat sweeping with broom">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great use of the alt attribute with descriptive text

<main>
<section class="portfolio">
<h2>Personal Portfolio Project</h2>
<a href="https://github.com/eggoweggo/personal-portfolio-site">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add the target attribute to your links and it will open them in a new tab. This keeps the user on your page and be able to access other content

an example is here https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_a_target

color: #3e3e3e;
font-weight: 300;
background-color: #A3AC9C
/* background: url('../images/background.png') */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove unused code

</nav>
</header>
<main>
<p>My name is Shannon Bellemore and I am currently a software developer student at Ada Developers Academy.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some padding around this text. It was hard to read the beginning of it on safari.

list-style-type: none;
}

a {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make it more user friendly I would add an effect to your links so folks know its a link. Maybe when you hover the mouse could change to a pointer or the text could change colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants