Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alexa Coffman - Whales #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Alexa Coffman - Whales #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e1bd49
added content for index, about, portfolio, styles
AlexaCoffman May 26, 2022
b521384
added border to portfolio items
AlexaCoffman May 27, 2022
07ece0a
beautify html, adjust portfolio item padding
AlexaCoffman May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed assets/personal-portfolio_wireframe1.png
View file
Open in desktop
Binary file not shown.
Binary file removed assets/personal-portfolio_wireframe2.png
View file
Open in desktop
Binary file not shown.
Binary file added images/blanket.jpeg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/iceland.jpeg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/me.jpeg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
34 changes: 28 additions & 6 deletions pages/about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,34 @@
<!DOCTYPE html>
<html lang="en">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<meta charset="UTF-8">
<link href="/styles/styles.css" rel="stylesheet">
<link href="/styles/about.css" rel="stylesheet">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>About</title>
</head>
<body>


<body class="container">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting a class on body is a little redundant, since there is only one per page (unless your page is super invalid) and you can just select by the element in your CSS.

<header>
<h1>
About
</h1> </header>
<nav class="nav">
<ul>
<li><a href="index.html">home</a></li>
<li><a href="about.html">about</a></li>
<li><a href="portfolio.html">portfolio</a></li>
</ul>
</nav>
<section> <img class="about-pic" src="/images/me.jpeg" alt="Photo of Alexa Coffman">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style:

Suggested change
<section> <img class="about-pic" src="/images/me.jpeg" alt="Photo of Alexa Coffman">
<section>
<img class="about-pic" src="/images/me.jpeg" alt="Photo of Alexa Coffman">

<h2>Alexa Coffman</h2>
<p>Currently: Software Engineering Student at Ada Developers Academy</p>
<p>Living: Greater Seattle Area</p>
<p>Doing: Cooking, knitting, video games, reading trash</p>
</section>
<footer class="footer"> &copy; 2022 Alexa Coffman </footer>
</body>

</html>
29 changes: 23 additions & 6 deletions pages/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,29 @@
<!DOCTYPE html>
<html lang="en">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<meta charset="UTF-8">
<link href="/styles/styles.css" rel="stylesheet">
<link href="/styles/about.css" rel="stylesheet">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Alexa Coffman's Portfolio</title>
</head>
<body>


<body class="container">
<header>
<h1>
Alexa Coffman's Portfolio
</h1> </header>
<nav class="nav">
<ul>
<li><a href="index.html">home</a></li>
<li><a href="about.html">about</a></li>
<li><a href="portfolio.html">portfolio</a></li>
</ul>
</nav>
<section> <img id="lighthouse" alt="Photo of a lighthouse on a cliff in Iceland" src="/images/iceland.jpeg"> </section>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I see why it was upset about this.

A section that just contains a single image doesn't really make much sense. Ideally you would just have the image here and tweak your styles to accommodate that (using things like adjacent sibling selectors or nth-child if you wanted to make it general.

Though honestly the easiest is probably to just add a rule around img tags in your CSS. If you really need a wrapper element here you could also fallback to using a div.

<footer class="footer"> &copy; 2022 Alexa Coffman </footer>
</body>

</html>
36 changes: 30 additions & 6 deletions pages/portfolio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,36 @@
<!DOCTYPE html>
<html lang="en">

<head>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
<meta charset="UTF-8">
<link href="/styles/styles.css" rel="stylesheet">
<link href="/styles/portfolio.css" rel="stylesheet">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Portfolio</title>
</head>
<body>


<body class="container">
<header>
<h1>
Portfolio
</h1> </header>
<nav class="nav">
<ul>
<li><a href="index.html">home</a></li>
<li><a href="about.html">about</a></li>
<li><a href="portfolio.html">portfolio</a></li>
</ul>
</nav>
<section>
<ul class="portfolio-container">
<li><a class="portfolio-item" href="https://github.com/AlexaCoffman/task-list-api">Task List API</a></li>
<li><a class="portfolio-item" href="https://alexacoffman.com">Photography</a></li>
<li><a class="portfolio-item" href="/images/blanket.jpeg">Blanket</a></li>
<li><a class="portfolio-item" href="https://github.com/AlexaCoffman/swap-meet">Swap Meet</a></li>
</ul>
</section>
Comment on lines +25 to +32
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This should just be a ul.

<footer class="footer"> &copy; 2022 Alexa Coffman </footer>
</body>

</html>
7 changes: 7 additions & 0 deletions styles/about.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
.about-pic {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might make sense as an id since there will usually only be one about pic per page.

(Though I suppose if you added articles with bylines then having multiples on a page could make sense.)

Generally I like to make things where there is only one an id just for clarity that it's an individual element. That and it uses higher precedence so it's easier to override styles that way.

display:inline;
width: 400px;
float: right;
margin-left: 5px;
margin-bottom: 5px;
}
27 changes: 27 additions & 0 deletions styles/portfolio.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
.portfolio-container {
display: flex;
flex-wrap: wrap;
justify-content: space-evenly;
padding-left: 0;
}
.portfolio-item {
font-weight: bold;
background-color: #dab785;
margin: 25px;
padding: 20px;
border: solid;
}
.portfolio-item:hover {
color:#70a288;
}
body {
background-color: #d5896f;
color: #04395e;
}
a {
color: #04395e;
text-decoration: none;
}
a:hover {
color: #dab785
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Missing ;.

Technically ;s are only separators in CSS so you can leave it off the last one. It's just good for preventing bugs so you don't need to remember to add it if you add another rule to the block.

}
50 changes: 50 additions & 0 deletions styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
head {
font-weight: 300
}
header {
text-align: center;
}
.container {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per previous note:

Suggested change
.container {
body {

display: grid;
width: 60vw;
height: auto;
margin-left: auto;
margin-right: auto;
grid-template-columns: 100%;
grid-template-rows: 150px;
}
body {
background-color: #04395e;
color: #d5896f;
font-family: andale mono;
align-items: center;
}
nav {
text-align:center;
background-color: #70a288;
margin-bottom: 20px;

}
h1 {
vertical-align: middle;
}
li {
display: inline;
}
a {
color: #dab785;
text-decoration: none;
}
a:hover {
color: #d5896f
}
nav a {
padding: 8px;
text-transform: uppercase;
}
footer {
margin-bottom: -400px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this is interesting.

I'm curious what layout issue required doing this. If you're interested during office hours I'd be happy to take a look at any odd CSS issues you've got.

}
#lighthouse {
width: 60vw;
}