Remove __builtin_add_overflow

acvictor · Feb 8, 2024 · cf8c89e · cf8c89e
1 parent c5e0d7b
commit cf8c89e
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/velox/functions/sparksql/DateTimeFunctions.h b/velox/functions/sparksql/DateTimeFunctions.h
@@ -365,10 +365,7 @@ struct DateFromUnixDateFunction {
   VELOX_DEFINE_FUNCTION_TYPES(T);
 
   FOLLY_ALWAYS_INLINE void call(out_type<Date>& result, const int32_t& value) {
-    // If addititon does not overflow the result is valid.
-    // Max and min value of result here is numeric_limits<int32_t>::max() and
-    // numeric_limits<int32_t>::min().
-    __builtin_add_overflow(0, value, &result);
+    result = value;
   }
 };