Resolve comment

acvictor · Apr 23, 2024 · cb7c124 · cb7c124
1 parent e7f5eaf
commit cb7c124
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/velox/core/SimpleFunctionMetadata.h b/velox/core/SimpleFunctionMetadata.h
@@ -590,9 +590,9 @@ class SimpleFunctionMetadata : public ISimpleFunctionMetadata {
 
     builder.returnType(analysis.outputType);
     int32_t position = 0;
+    VELOX_CHECK_GT(ConstantChecker::getSize(), 0);
     for (const auto& arg : analysis.argsTypes) {
-      if (ConstantChecker::getSize() > 0 &&
-          ConstantChecker::isConstant[position++]) {
+      if (ConstantChecker::isConstant[position++]) {
         builder.constantArgumentType(arg);
       } else {
         builder.argumentType(arg);