Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guard): do not use host header on http2 for guard #3525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joelwurtz
Copy link
Contributor

@joelwurtz joelwurtz commented Dec 10, 2024

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Host header should not be used when the request comes from HTTP2.

Also i'm wondering if this Host should be checked with the connect info object instead so it can use forwarded header ? (But need #3524 to be safe)

@robjtede robjtede added B-semver-patch A-web project: actix-web labels Dec 10, 2024
@joelwurtz joelwurtz force-pushed the fix/host-header-http2 branch from baa59a3 to 228fd81 Compare December 11, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants