Respect username on macOS self-hosted runners

[fkorotkov]

Description:

Right now it's hardcoded to "runner". I'm not sure why it's hardcoded on macOS in the first place. I tried to dig some history in #466 made by @techman83 but have not spent enough time to get to the root cause.

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[techman83]

IIRC I didn't change the mac path, because this related to how actions/setup-python compiles (at least compiled when I submitted my PR) the python libraries. Covered by the commit comment:

Shared libraries for the Mac python builds are not configured with the
relocatable flag, thus must always be configured with the hosted path.

It'll be worth referencing where this was fixed upstream, but there was definitely a reason 🙂

[dmitry-shibanov]

Hello @fkorotkov. Could you please run the npm run format && npm run build command ?

[fkorotkov]

@dmitry-shibanov my bad! I only ran npm run build. Formatted code in 2750121 and npm run builded just in case but nothing changed.

[jonluca]

Hi Is there an update on this? Would be great to get this working :)

[kvasilye]

Any update on merging this?

We use self hosted MacOS runners and are unable to upgrade to python-setup v5

[oscarbetancurj]

Hi. When are you going to merge this? I have same issue right now. Thanks!!

[priya-kinthali]

Hello @fkorotkov 👋,
Thank you for your contribution!
We have reviewed this PR and encountered an error when testing it on a self-hosted runner with Python versions below 3.11. It appears that the changes are not compatible with these earlier versions.
The error is as follows:
Reason: tried: '/Users/runner/hostedtoolcache/Python/3.10.11/x64/lib/libpython3.10.dylib' (no such file)
You can view the detailed logs here.
Could you please take a look?
Thanks in advance!

[kvasilye]

Hello, can this be merged please?

This bug is blocking us from upgrading out of v3.

[fkorotkov]

@priya-kinthali sorry I missed you message. The link does not work now and I'm not sure how this change could work with one version of Python and not another. On a self-hosted runner with runner username it should work as expected.

For anyone looking for a workaroud, for our managed GitHub Actions Runners service we ended up linking /Users/runner in our virtual machines:

https://github.com/cirruslabs/macos-image-templates/blob/159d4c1c3662c02c7148f2fc9fae23f4e0230c56/templates/base.pkr.hcl#L74-L82

[priya-kinthali]

Hello @fkorotkov 👋,
Thank you for your patience and for providing the workaround. Upon testing the changes, we encountered the same error on a self-hosted runner with Python versions below 3.11. Please find the run here.