Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all processors when installing zstd #11067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fahhem
Copy link

@fahhem fahhem commented Dec 1, 2024

Description

Speeds up my builds from 93s to 37s (four core) for the install-zstd.sh step

Related issue:

None

Check list

  • [n/a] Related issue / work item is attached
  • [n/a] Tests are written (if applicable)
  • [n/a] Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

Speeds up my builds from 93s to 37s (four core) for the install-zstd.sh step
@Kichura
Copy link

Kichura commented Dec 1, 2024

One question i have yet to ask: Is this change stable in CI aswell just like using zstd in single-threaded mode?

@fahhem
Copy link
Author

fahhem commented Dec 2, 2024 via email

@fahhem
Copy link
Author

fahhem commented Dec 2, 2024

@Kichura Can you approve it so the workflows can run and we can see if it's stable on CI?

@Kichura
Copy link

Kichura commented Dec 3, 2024

@Kichura Can you approve it so the workflows can run and we can see if it's stable on CI?

I am not a member of this repo, therefore i can't greenlight this but i will approve it cuz it's interesting.

@subir0071
Copy link
Contributor

We are in the process of checking this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants