feat(helm): move dind to sidecar #3842
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velkovb
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
kostadin-lazarov1
approved these changes
Dec 12, 2024
kostadin-lazarov1
approved these changes
Dec 12, 2024
kostadin-lazarov1
approved these changes
Dec 12, 2024
Alexizx00789999
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
dindcontainer as a SidecarCurrently, in
dindmode we run 2 containers in the pod. This results in them having their own lifecycles. In the case ofdindthis could lead to issues as the process in therunnercontainer depend on the docker socket from thedindcontainer. We hit that multiple times were we wanted to wait for jobs to complete and the runner container stays alive as we handle the SIGTERM manually butdinddies and the jo fails. When running as a Sidecar containerdindstays alive as long as the pod is alive and we don't need to do custom SIGTERM handling there.Since 1.29 Sidecars are enabled by default so this PR moves the
dindcontainer as a Sidecar if the version is above 1.29.