Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign_response when response body contains array with Grape 0.19.x #16

Open
wants to merge 1 commit into
base: 2.0
Choose a base branch
from

Conversation

janost
Copy link
Contributor

@janost janost commented Jan 27, 2017

No description provided.

pdrakeweb
pdrakeweb previously approved these changes Feb 6, 2017
@pdrakeweb pdrakeweb dismissed their stale review February 6, 2017 13:28

Wrong button.

Copy link
Contributor

@pdrakeweb pdrakeweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rack spec (http://rack.rubyforge.org/doc/SPEC.html) demands that the response body yield only String values. I believe this is not a bug here, but a bug in the software which results in non-String body parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants