Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace abandoned composer package 'webmozart/path-util' #4670

Closed
wants to merge 3 commits into from

Conversation

hkorik
Copy link
Contributor

@hkorik hkorik commented Mar 21, 2023

Motivation
Fixes #4669 . As outlined in the projects deprecation notice this should be replaced with the symfony filesystem component.

Proposed changes
Replaces the method used from the Path utility from webmozart/path-util with a replacement method from the symfony/filesystem component. Removes the composer direct dependency on the abandoned project.

Testing steps
Ensure the blt internal:add-to-project command successfully adds custom blt related files to the expected .gitignore file within the configured project repo.root directory.

@hkorik hkorik changed the title Replace composer abandoned 'webmozart/path-util' Replace abandoned composer package 'webmozart/path-util' Mar 21, 2023
@danepowell
Copy link
Contributor

Unfortunately, I don't think we can do this until Drupal 9 is EOL, since Drupal 9 requires Symfony 4 and the path utilities were only added to Symfony 5.

@danepowell danepowell closed this Apr 3, 2023
@gaards
Copy link

gaards commented Oct 24, 2023

We are about a week away from D9 EOL, could this PR now be revisited/reopened/recreated?

https://www.drupal.org/about/core/policies/core-release-cycles/schedule

@danepowell
Copy link
Contributor

Yes, we will revisit this in the near future

@danepowell
Copy link
Contributor

Superseded by #4706

@hkorik thanks for your PR; if you really want credit for this commit, let me know and I'll try to cherry-pick it into the new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLT-5208: Replace abandoned composer package 'webmozart/path-util'
3 participants