ACMS-4373: Make Acquia CMS Toolbar and Tour work independent. #1909
+136
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373
branch
from
a9b7619 to
a9f5c77
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373
branch
from
a9f5c77 to
4c1e88a
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373
branch
from
4c1e88a to
4c627c9
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373
branch
from
4c627c9 to
0c2add3
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373
branch
from
32406f4 to
79b459d
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373
branch
from
79b459d to
9ffdafa
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
force-pushed
the
ACMS-4373
branch
from
9ffdafa to
e095710
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
apathak18
reviewed
Dec 23, 2024
| case 'content_administrator': | ||
| $role->grantPermission('access acquia cms tour dashboard'); | ||
| user_role_grant_permissions('content_administrator', ['access acquia cms tour dashboard']); |
There was a problem hiding this comment.
Why passing hard-coded role name?
There was a problem hiding this comment.
We are assigning permissions exclusively to the role with the matching ID content_administrator.
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
…ntity_insert hooks.
rajeshreeputra
force-pushed
the
ACMS-4373
branch
from
014e109 to
fd16a68
Compare
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
rajeshreeputra
requested review from
chandan-singh7929,
vishalkhode1,
apathak18 and
deepakmishra2
rajeshreeputra
temporarily deployed
to
acquia_code_deployment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Toolbar and Tour should work independently without the Acquia Drupal Starter Kit Common module.
Fixes #ACMS-4373
Proposed changes
Remove Acquia Drupal Starter Kit Common module dependency.
Alternatives considered
NA
Testing steps
Follow from ticket
Merge requirements