Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMS Starterkit command with drush install and composer options #52

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

fiasco
Copy link

@fiasco fiasco commented Aug 26, 2022

No description provided.

@nagwani
Copy link

nagwani commented Aug 26, 2022

Can we demo this before being merged?

@fiasco
Copy link
Author

fiasco commented Sep 5, 2022

Just noting the CI job failure is because of detected php 7.3 incompatibilities:

FILE: .../acquia-cms-starterkit/src/Helpers/Task/Steps/ValidateDrupal.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 18 | ERROR | Typed properties are not supported in PHP 7.3 or
    |       | earlier
    |       | (PHPCompatibility.Classes.NewTypedProperties.Found)
 32 | ERROR | Typed properties are not supported in PHP 7.3 or
    |       | earlier
    |       | (PHPCompatibility.Classes.NewTypedProperties.Found)
----------------------------------------------------------------------

These could be safely ignored. Though is there a ticket somewhere to clean those up?

@rajeshreeputra
Copy link
Contributor

This can be closed as PR is already merged into develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants