Avoid permissions errors for chown .well-known #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinoid
force-pushed
the
fix-well-known-perms
branch
2 times, most recently
from
a0bbf10 to
d19308b
Compare
kevinoid
force-pushed
the
fix-well-known-perms
branch
from
d19308b to
bf6a0e6
Compare
|
For reference, it does not appear that the issue was fixed. I'm open to providing an alternative implementation if this one was found to be unacceptable. |
|
sorry, it was closed by accident. |
kevinoid
force-pushed
the
fix-well-known-perms
branch
from
bf6a0e6 to
c90ec54
Compare
When acme.sh is run as a non-root user different from the owner of the webroot directory it is unable to change the owner of the files in .well-known to that user, causing permissions errors. Avoid this by making the files world-readable. These files should pose no disclosure risk since they are sent in cleartext during the HTTP Identifier Validation Challenge[1] and may already be exposed by directory enumeration, depending on server settings. AFAIK they should be safe to expose as world-readable in all cases. 1. https://ietf-wg-acme.github.io/acme/#rfc.section.7.2 Fixes acmesh-official#32 Signed-off-by: Kevin Locke <[email protected]>
kevinoid
force-pushed
the
fix-well-known-perms
branch
from
c90ec54 to
22dfedf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When acme.sh is run as a non-root user different from the owner of the webroot directory it is unable to change the owner of the files in .well-known to that user, causing permissions errors. Avoid this by
making the files world-readable.
These files should pose no disclosure risk since they are sent in cleartext during the HTTP Identifier Validation Challenge and may already be exposed by directory enumeration, depending on server
settings. AFAIK they should be safe to expose as world-readable in all cases.
Fixes #32
Thanks for considering,
Kevin