Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional cmd line parameter NSUPDATE_OPT to dns_nsupdate api #5224

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Add optional cmd line parameter NSUPDATE_OPT to dns_nsupdate api #5224

merged 5 commits into from
Sep 13, 2024

Conversation

gmanic
Copy link
Contributor

@gmanic gmanic commented Jul 24, 2024

To enable TCP communication with nameserver (-v flag of nsupdate) an additional parameter NSUPDATE_OPT was added.
It will be saved/read from config.
Documentation has not been updated, as WIKI is not in forked repo; hence, documentation update makes no sense at this point in time.

This is not a new dns_api.

gmanic added 5 commits May 14, 2023 20:02
@gmanic
Enable additional command line parameters for nsupdate
af759f2 
For being able to use e.g. "-v" to use TCP communication with the NSUPDATE_SERVER -> NSUPDATE_OPT has been added.
NSUPDATE_OPT will be plainly added to the command line of nsupdate.
NSUPDATE_OPT will also be saved to conf respectively read from conf
@gmanic
Correct Typo, add -n test
cd2b7cd 
Added a test for non-zero-string, corrected type ZONE instead of OPT
@gmanic
Push for actions
f99d6da
@gmanic
Update dns_nsupdate.sh
0b0476e
@gmanic
Update dns_nsupdate.sh
bcb7e5f 
Corrected required variable double quote
@github-actions GitHub Actions
Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@gmanic
Copy link
Contributor Author

gmanic commented Jul 24, 2024

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

Have reviewed above documents. This is no new api, just an enhancement of dns_nsupdate api.

@gmanic
Copy link
Contributor Author

gmanic commented Aug 28, 2024

How about reviewing & merging this PR?

@Neilpang Neilpang merged commit adff28d into acmesh-official:dev Sep 13, 2024
1 check passed
@fraenki fraenki mentioned this pull request Sep 16, 2024
Merged
@fraenki
Copy link
Contributor

fraenki commented Sep 16, 2024 •
edited
Loading

@gmanic Maybe you could review #5285 and ensure that your use-case still works as expected when applying the fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmanic @fraenki @Neilpang