Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding paid event routes #27

Open
wants to merge 5 commits into
base: events_ticketing_unification
Choose a base branch
from
Open

Adding paid event routes #27

wants to merge 5 commits into from
+1,924 −1,449

Conversation

EthM370
Copy link

@EthM370 EthM370 commented Dec 3, 2024

Adding paid events plugin with get and single attribute update functionality.

@EthM370 EthM370 requested a review from tarashagarwal December 3, 2024 01:07
@EthM370 EthM370 self-assigned this Dec 3, 2024
@EthM370 EthM370 requested review from a team as code owners December 3, 2024 01:07
devksingh4
devksingh4 requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@devksingh4 devksingh4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please write unit tests along with the code
  2. we camel-case our routes so that its consistent - so for example /api/v1/paidEvents/merch - lets try to rewrite those names

Overall good start though!

devksingh4
devksingh4 reviewed Dec 3, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
devksingh4
devksingh4 reviewed Dec 3, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
devksingh4
devksingh4 reviewed Dec 3, 2024
View reviewed changes
src/routes/paidevents.ts Outdated Show resolved Hide resolved
@EthM370
Fixed
0bbd21f
@EthM370
Rename paidevents.ts to paidEvents.ts
079d4ff 
Fixed case issues during git push
EthM370
EthM370 commented Dec 9, 2024
View reviewed changes
Copy link
Author

@EthM370 EthM370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All pending integration and lint issue fixed, still need to write unit test

@tarashagarwal tarashagarwal changed the base branch from main to events_ticketing_unification December 21, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devksingh4 devksingh4 devksingh4 requested changes

@tarashagarwal tarashagarwal Awaiting requested review from tarashagarwal

Assignees

@EthM370 EthM370

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EthM370 @devksingh4