Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows #26

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Support Windows #26

wants to merge 4 commits into from

Conversation

achimnol
Copy link
Owner

@achimnol achimnol commented Mar 17, 2021

Yes, I just bought a new Windows desktop.

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #26 (de710d4) into main (17b47b9) will decrease coverage by 13.99%.
The diff coverage is 36.05%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   72.34%   58.34%   -14.00%     
===========================================
  Files          10       13        +3     
  Lines         846     1030      +184     
===========================================
- Hits          612      601       -11     
- Misses        234      429      +195     
Impacted Files Coverage Δ
src/aiotools/compat.py 70.00% <0.00%> (-30.00%) ⬇️
src/aiotools/fork_windows.py 0.00% <0.00%> (ø)
src/aiotools/fork.py 76.19% <73.68%> (+29.52%) ⬆️
src/aiotools/fork_unix.py 77.04% <77.04%> (ø)
src/aiotools/fork_base.py 77.77% <77.77%> (ø)
src/aiotools/context.py 36.27% <0.00%> (-58.83%) ⬇️
src/aiotools/taskgroup.py 89.15% <0.00%> (-1.21%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b47b9...de710d4. Read the comment docs.

* TODO: implement passing of the main function to child processes
* Thanks to the CPython's standard multiprocessing module!
@youknowone
Copy link
Contributor

if this patch will take time, could you consider to merge #47 first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants