Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Add Incomplete Loadout Tooltips #10572

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Arsenal - Add Incomplete Loadout Tooltips #10572

wants to merge 3 commits into from
+14 −0

Conversation

SpicyBagpipes
Copy link
Contributor

When merged this pull request will:

  • Adds CBA option for incomplete loadout tooltips
  • Will give a tooltip for each unique item that is missing from the arsenal (Not working on null items is intended)

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@SpicyBagpipes
Copy link
Contributor Author

Don't know how to mark a PR as draft, but I have no idea why this doesn't work. The command runs and I cannot see any syntax errors.

@SpicyBagpipes SpicyBagpipes marked this pull request as draft December 19, 2024 01:20
BrettMayson
BrettMayson reviewed Dec 20, 2024
View reviewed changes
addons/arsenal/functions/fnc_fillLoadoutsList.sqf Outdated
@@ -104,7 +104,7 @@ if (GVAR(currentLoadoutsTab) != IDC_buttonSharedLoadouts) then {
} else {
if (_unavailableItemsList isNotEqualTo []) then {
_contentPanelCtrl lnbSetColor [[_newRow, 1], [1, 1, 1, 0.25]]; // Gray
if GVAR(unavailableItemsTooltip) then {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way it was is valid though, should have the () cause that's the standard, but this wouldn't cause any issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I can think of that could be the issue is same frame execution... But that'd make absolutely zero sense for a tooltip and executing next frame was not resolving the issue - quite possibly user error though given it is me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does lnb support tooltips? might be a style property thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://community.bistudio.com/wiki/lnbSetTooltip

Not too well versed with GUI but appears so to me

@LinkIsGrim
Copy link
Contributor

IMO doesn't need to be a setting?

@SpicyBagpipes
Copy link
Contributor Author

IMO doesn't need to be a setting?

Lots of loadouts would make moving mouse over loadouts screen obnoxious imo

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Dec 20, 2024
@LinkIsGrim LinkIsGrim added this to the Ongoing milestone Dec 20, 2024
@LinkIsGrim LinkIsGrim added the kind/setting Release Notes: **SETTINGS:** label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim left review comments

@DartRuffian DartRuffian DartRuffian left review comments

@BrettMayson BrettMayson BrettMayson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/setting Release Notes: **SETTINGS:**
Projects
None yet
Milestone
Ongoing
Development

Successfully merging this pull request may close these issues.
4 participants
@SpicyBagpipes @LinkIsGrim @BrettMayson @DartRuffian