Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Migrate to lerna v7 #796

Merged
merged 4 commits into from
Oct 19, 2023
Merged

chore(deps): Migrate to lerna v7 #796

merged 4 commits into from
Oct 19, 2023

Conversation

martinhalford
Copy link
Member

Closes #779

Lerna Bootstrap has been deprecated as of Lerna version 7.

The linking of packages/* is now handled by npm using workspaces.

Changes

  • Remove lerna bootstrap.
  • Add workspaces to package.json - so that npm handles package linking.
  • Update devDependencies: "lerna": "^7.3.1",
  • Remove references to lerna bootstrap from DEVELOPERS.md.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

Signed-off-by: Martin Halford <[email protected]>
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go all the way and remove the dependency on Lerna.

Dan did a similar thing for markdown-transform recently, https://github.com/accordproject/markdown-transform/pull/570/files

Can you also review the GitHub Actions scripts (in .github/workflows) too? Especially the build and publish steps.

DEVELOPERS.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Signed-off-by: Martin Halford <[email protected]>
@martinhalford
Copy link
Member Author

Let's go all the way and remove the dependency on Lerna.

Dan did a similar thing for markdown-transform recently, https://github.com/accordproject/markdown-transform/pull/570/files

Can you also review the GitHub Actions scripts (in .github/workflows) too? Especially the build and publish steps.

OK. Let me see what I can do.

@martinhalford
Copy link
Member Author

Let's go all the way and remove the dependency on Lerna.
Dan did a similar thing for markdown-transform recently, https://github.com/accordproject/markdown-transform/pull/570/files
Can you also review the GitHub Actions scripts (in .github/workflows) too? Especially the build and publish steps.

OK. Let me see what I can do.

@mttrbrts

I've removed Lerna completely. However, some stuff has been modified but not tested - most notably .github/workflows which were copy/pastes of @dselman's code from Markdown Transform.

I've also tweaked the license.config.json files; and renamed lerna.json to config.json and tweaked it, as that was still being referenced by scripts/timestamp.js.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6569311786

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.42%

Totals Coverage Status
Change from base Build 6096098290: 0.0%
Covered Lines: 779
Relevant Lines: 872

💛 - Coveralls

@mttrbrts mttrbrts merged commit ac12aa3 into accordproject:main Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lerna Bootstrap no longer supported as of Lerna v7.0
3 participants