Ryan FE seminar 1 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
callasio
commented
Jul 23, 2024
callasio
commented
- "개"를 붙인 이후에는 커서 작동을 직관적으로 만들어야 하는데 이 부분은 제대로 구현하지 못했습니다
|
엥 근데 이러니까 zod 세미나 내용까지 같이 commmit되네요 이거 merge하면 다른사람 zod 세미나 내용 때문에 안될 거 같은데 merge는 안하고 남겨놓을까요? |
wjeongchoi
reviewed
Jul 27, 2024
Comment on lines
+1
to
+12
| export const metadata = { | ||
| title: 'Next.js', | ||
| description: 'Generated by Next.js', | ||
| } | ||
|
|
||
| export default function RootLayout({ children }) { | ||
| return ( | ||
| <html lang="en"> | ||
| <body>{children}</body> | ||
| </html> | ||
| ) | ||
| } |
| @@ -0,0 +1,102 @@ | |||
| /* eslint-disable react/no-children-prop */ | |||
There was a problem hiding this comment.
실제로 태스크할 때는 eslint disable 최대한 사용하지 말아주세요!
Comment on lines
+18
to
+23
| const MailInput = styled.div` | ||
| display: flex; | ||
| flex-direction: row; | ||
| gap: 10px; | ||
| width: 100%; | ||
| ` |
There was a problem hiding this comment.
FlexWrapper도 아마 이걸 대체할 수 있을거에요!
Comment on lines
+40
to
+46
| const validateEmailDomain = (domain: string) => { | ||
| const domainRegex = /^[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/; | ||
| if (!domainRegex.test(domain)) { | ||
| return '유효한 메일 도메인을 입력하세요.'; | ||
| } | ||
| return ''; | ||
| }; |
| setIdErrorMessage(validateEmailId(value)); | ||
| } | ||
| }/> | ||
| <div style={{ position: 'relative', top: '8px' }}>@</div> |
There was a problem hiding this comment.
웬만하면 div 그대로는 사용하지 말아주세요! 이 경우에는 Typography를 사용할 수 있겠네요
Comment on lines
+78
to
+86
| <Button | ||
| style={{height: '36px'}} | ||
| children={fixDomain ? "직접 입력" : "kaist.ac.kr"} | ||
| onClick={(_) => { | ||
| if (!fixDomain) setDomainErrorMessage(""); | ||
| setMailDomain(fixDomain ? "" : "kaist.ac.kr"); | ||
| setFixDomain(!fixDomain); | ||
| }} | ||
| /> |
Comment on lines
+56
to
+60
| const StyledInputWrapper = styled.div` | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 4px; | ||
| ` |
wjeongchoi
reviewed
Aug 9, 2024
Comment on lines
+20
to
+30
| const savedNumber = userProfile?.phoneNumber; | ||
|
|
||
| const [phoneNumber, setPhoneNumber] = useState(savedNumber ?? ""); | ||
| const [phoneInput, setPhoneInput] = useState(phoneNumber); | ||
| const [phoneError, setPhoneError] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| if (userProfile) { | ||
| setPhoneNumber(savedNumber ?? ""); | ||
| } | ||
| }, [userProfile, savedNumber]); |
There was a problem hiding this comment.
저도 항상 겪는 문제이지만.. 처음에 유저 전화번호가 잘 안 받아와지는 것 같아요
wjeongchoi
reviewed
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.