Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of logo in mobile #816

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

malloc3141
Copy link
Contributor

요약 *

It closes #763

스크린샷

이후 Task *

  • 없음

@malloc3141 malloc3141 added bug Something isn't working front-end labels Aug 23, 2024
@malloc3141 malloc3141 self-assigned this Aug 23, 2024
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for jazzy-klepon-c756b5 ready!

Name Link
🔨 Latest commit d49ee1a
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-klepon-c756b5/deploys/66c8829ab2d28a000855bc29
😎 Deploy Preview https://deploy-preview-816--jazzy-klepon-c756b5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 62
Accessibility: 94
Best Practices: 100
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@malloc3141
Copy link
Contributor Author

@babycroc 엥 해결 됐나요? deploy link 접속해보니까 해결이 안 되어있어서 다시 작업하려고 했는데

@malloc3141 malloc3141 marked this pull request as draft August 23, 2024 12:39
@babycroc
Copy link
Contributor

@babycroc 엥 해결 됐나요? deploy link 접속해보니까 해결이 안 되어있어서 다시 작업하려고 했는데

아 안됐구나ㅋㅋㅋㅋ 약간 됐겠거니 하고 무한신뢰(?)하며 어프루브를 해버렸지모야

@malloc3141
Copy link
Contributor Author

로컬에서 이것저것 해보고 있긴한데 뭘 해도 해결이 안되네요 ㅜㅜ

@babycroc
Copy link
Contributor

@malloc3141 https://www.redonearth.com/nextjs-svg-mobile-error 검색해보니 이런 게 나오는데 함 볼래???

@babycroc
Copy link
Contributor

지금 들어가있는 svg가 너무 작아서 그런걸지도 내가 피그마에 큰 거 하나 만들어볼테니 그거 함 export해봐도 좋을듯

@malloc3141
Copy link
Contributor Author

malloc3141 commented Aug 23, 2024

@malloc3141 https://www.redonearth.com/nextjs-svg-mobile-error 검색해보니 이런 게 나오는데 함 볼래???

음 svg 확인해보니까 width랑 height는 다 있어서 이 문제는 아닌 것 같긴 해요 이따가 사이즈 큰걸로 한번 바꿔보긴 할게용

@babycroc
Copy link
Contributor

웅 그냥 사파리 이슈인 것 같기도... :sadblob: 사이즈 큰걸로 대체해도 안되면 일단 미뤄둬도 될듯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mobile footer logo resolution bad
2 participants