1229 impl mee007 009 011 #1232
Open
1229 impl mee007 009 011 #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Engineer-JJHaMa
requested changes
Nov 27, 2024
| ); | ||
| return result; | ||
| } | ||
|
|
||
| @Post("/executive/meetings/meeting/:meetingId/agendas") |
There was a problem hiding this comment.
❗ Post가 아니라 Get인것 같아요. 혹시 테스트중에는 문제가 없었나요?
Comment on lines
+538
to
+544
| .where( | ||
| and( | ||
| eq(MeetingMapping.meetingAgendaId, agendaId), | ||
| eq(MeetingMapping.meetingId, meetingId), | ||
| ), | ||
| ) | ||
| .then(result => { |
There was a problem hiding this comment.
❓ 여기선 soft deletion을 필터링할 필요가 없나요?
Comment on lines
+130
to
+139
| @Executive() | ||
| @Delete("/executive/meetings/meeting/:meetingId/agendas/agenda/:agendaId") | ||
| @UsePipes(new ZodPipe(apiMee011)) | ||
| async postExecutiveMeetingAgendaImport( | ||
| @GetExecutive() user: GetExecutive, | ||
| @Param() param: ApiMee011RequestParam, | ||
| ): Promise<ApiMee011ResponseCreated> { | ||
| const result = await this.meetingService.postExecutiveMeetingAgendaImport( | ||
| user.executiveId, | ||
| param, |
There was a problem hiding this comment.
❗ 컨벤션에 맞지 않는것 같아요. 확인해주세요!
| meetingId, | ||
| meetingAgendaId: agendaId, | ||
| meetingAgendaPosition: newPosition, // Set position to the next available value | ||
| meetingAgendaEntityType: 1, // Entity type is fixed to 1 |
There was a problem hiding this comment.
💊 EntityType이 무엇인지 Enum을 통해 정의하고 주석이 있으면 이해하기 편할거 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It closes #1229
MEE 007, 009, 011 API를 구현하였습니다.
interface / Controller / repository / service 모두 구현했습니다.
그리고 중간에 Mapping 테이블을 다루는 부분에서 둘이 나누어 구현하다 보니 약간 다른 점이 존재했는데 질문드리고싶네용
스크린샷
이후 Task *
MEE 006~011의 Req/Res의 구조를 조금 리팩토링하고 구조를 단일화 시키는 것은 어떨지..!