NOISSUE: Change Role Name to Role ID #2612
Open
+1,784
−1,840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 45.43% 42.25% -3.19%
==========================================
Files 404 202 -202
Lines 50450 30093 -20357
==========================================
- Hits 22921 12715 -10206
+ Misses 25170 16411 -8759
+ Partials 2359 967 -1392 ☔ View full report in Codecov by Sentry. |
felixgateru
requested changes
Dec 23, 2024
api/http/util/errors.go
Outdated
| @@ -81,6 +81,9 @@ var ( | |||
| // ErrMissingRoleName indicates that role name are empty. | |||
| ErrMissingRoleName = errors.New("empty role name") | |||
|
|
|||
| // ErrMissingRoleID indicates that role name are empty. | |||
There was a problem hiding this comment.
Suggested change
| // ErrMissingRoleID indicates that role name are empty. | |
| // ErrMissingRoleID indicates that role id is empty. |
felixgateru
reviewed
Dec 23, 2024
|
This PR is depend on #2585 |
arvindh123
force-pushed
the
role_name_to_id
branch
from
aa834d4 to
6c8bee9
Compare
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
arvindh123
force-pushed
the
role_name_to_id
branch
from
6c8bee9 to
2e14564
Compare
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality:
Change from Role Name to Role ID
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes