-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Return certs on bootstrap view response #1855
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
- Coverage 67.34% 67.12% -0.22%
==========================================
Files 119 119
Lines 9411 9491 +80
==========================================
+ Hits 6338 6371 +33
- Misses 2402 2448 +46
- Partials 671 672 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
052aedc
to
efcdef7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
95de885
to
9e4345b
Compare
9e4345b
to
6f9a9c5
Compare
6f9a9c5
to
73c7d42
Compare
291871d
to
14a272c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI remarks.
00282e7
to
af028cf
Compare
8e487c7
to
5f36795
Compare
5f36795
to
0e2de4c
Compare
0e2de4c
to
2d72fca
Compare
@SammyOina |
2d72fca
to
83e5d58
Compare
I see but I don't expect them to clash |
60df296
to
c9ccff2
Compare
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
remove unrequired conditions Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
rename MFThing to ThingID rename MFKey to ThingKey rename mainflux_key to thing_key Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
c9ccff2
to
3170e94
Compare
Signed-off-by: SammyOina <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* return certs on bootstrap view response Signed-off-by: SammyOina <[email protected]> * return updated certs when updated Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * fix tests Signed-off-by: SammyOina <[email protected]> * simplify tests Signed-off-by: SammyOina <[email protected]> * use named query Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * use named params Signed-off-by: SammyOina <[email protected]> * fix typo Signed-off-by: SammyOina <[email protected]> * use inline error checks remove unrequired conditions Signed-off-by: SammyOina <[email protected]> * sort slices before comparison Signed-off-by: SammyOina <[email protected]> * rename mainflux_id to thing_id rename MFThing to ThingID rename MFKey to ThingKey rename mainflux_key to thing_key Signed-off-by: SammyOina <[email protected]> * remove mainflux_channels Signed-off-by: SammyOina <[email protected]> * simplify unmarshaller Signed-off-by: SammyOina <[email protected]> --------- Signed-off-by: SammyOina <[email protected]>
* return certs on bootstrap view response Signed-off-by: SammyOina <[email protected]> * return updated certs when updated Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * fix tests Signed-off-by: SammyOina <[email protected]> * simplify tests Signed-off-by: SammyOina <[email protected]> * use named query Signed-off-by: SammyOina <[email protected]> * fix test Signed-off-by: SammyOina <[email protected]> * use named params Signed-off-by: SammyOina <[email protected]> * fix typo Signed-off-by: SammyOina <[email protected]> * use inline error checks remove unrequired conditions Signed-off-by: SammyOina <[email protected]> * sort slices before comparison Signed-off-by: SammyOina <[email protected]> * rename mainflux_id to thing_id rename MFThing to ThingID rename MFKey to ThingKey rename mainflux_key to thing_key Signed-off-by: SammyOina <[email protected]> * remove mainflux_channels Signed-off-by: SammyOina <[email protected]> * simplify unmarshaller Signed-off-by: SammyOina <[email protected]> --------- Signed-off-by: SammyOina <[email protected]>
What does this do?
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
I have added modified parameters to openapi spec
Notes