NOISSUE - Add delete certs feature #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nyagamunene <[email protected]>
SammyOina
previously approved these changes
Nov 14, 2024
dborovcanin
requested changes
Nov 18, 2024
| @@ -32,6 +32,17 @@ func (req viewReq) validate() error { | |||
| return nil | |||
| } | |||
|
|
|||
| type deleteReq struct { | |||
| entityID string | |||
There was a problem hiding this comment.
Use certID or just id.
certs.go
Outdated
| @@ -90,4 +93,7 @@ type Repository interface { | |||
|
|
|||
| // ListRevokedCerts retrieves revoked lists from database. | |||
| ListRevokedCerts(ctx context.Context) ([]Certificate, error) | |||
|
|
|||
| // RemoveCerts deletes certs from database. | |||
| RemoveCerts(ctx context.Context, entityId string) error | |||
There was a problem hiding this comment.
Use singular RemovCert.
sdk/sdk.go
Outdated
| @@ -291,6 +298,12 @@ func (sdk mgSDK) ListCerts(pm PageMetadata) (CertificatePage, errors.SDKError) { | |||
| return cp, nil | |||
| } | |||
|
|
|||
| func (sdk mgSDK) DeleteCerts(entityID string) errors.SDKError { | |||
There was a problem hiding this comment.
Same, use singular DeleteCert.
service.go
Outdated
| @@ -271,6 +271,10 @@ func (s *service) ListCerts(ctx context.Context, pm PageMetadata) (CertificatePa | |||
| return certPg, nil | |||
| } | |||
|
|
|||
| func (s *service) RemoveCerts(ctx context.Context, entityId string) error { | |||
Signed-off-by: nyagamunene <[email protected]>
dborovcanin
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: it adds a feature for deleting multiple certs for an entity id.
What does this do?
It adds a feature for deleting multiple certs for an entity id.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes
Did you document any new/modified features?
No
Notes