Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CWE support in multiple importers #1526

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add CWE support in multiple importers #1526

wants to merge 11 commits into from

Conversation

ambuj-1211
Copy link
Collaborator

Fixes: #1093
This adds cwe data to following importers:

  • debian
  • fireeye
  • apache_httpd

@ambuj-1211
Copy link
Collaborator Author

@ziadhany I don't know why some tests related to API are failing please check what should I do to resolve that.

@ambuj-1211 ambuj-1211 force-pushed the add-cwe-support-in-multiple-importers branch from 229b70a to 131f37c Compare September 15, 2024 18:45
@ziadhany
Copy link
Collaborator

ziadhany commented Sep 16, 2024 •
edited
Loading

@ziadhany I don't know why some tests related to API are failing please check what should I do to resolve that.

@ambuj-1211 I don’t see any errors in the test. Please let it fail in the CI so I can investigate the issue.

@ambuj-1211
Copy link
Collaborator Author

@ziadhany please have a look on this I have resolved the issues which you indicated earlier.

@TG1999 TG1999 added this to the v36.0.0 - 3-next milestone Oct 15, 2024
ziadhany
ziadhany requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@ziadhany ziadhany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ambuj-1211, you are doing a great job! Please make the required changes, and I hope we can merge this PR this week.

vulnerabilities/importers/apache_httpd.py Outdated Show resolved Hide resolved
vulnerabilities/importers/apache_httpd.py Outdated Show resolved Hide resolved
vulnerabilities/importers/apache_httpd.py Outdated Show resolved Hide resolved
vulnerabilities/importers/apache_httpd.py Outdated Show resolved Hide resolved
vulnerabilities/importers/apache_httpd.py Outdated Show resolved Hide resolved
vulnerabilities/importers/debian.py Outdated Show resolved Hide resolved
vulnerabilities/importers/fireeye.py Outdated Show resolved Hide resolved
@ambuj-1211
Copy link
Collaborator Author

@ziadhany please review the changes

ziadhany
ziadhany reviewed Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@ziadhany ziadhany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ambuj-1211, the code looks good. Just run the importers, print the logs, and then we can merge.

@ambuj-1211
Copy link
Collaborator Author

@ziadhany Here are the logs
debian_logs.txt
apache_httpd_logs.txt
fireeye_logs.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziadhany ziadhany ziadhany requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@ziadhany ziadhany

Labels
None yet
Projects
None yet
Milestone
v36.0.0 - 3-next
Development

Successfully merging this pull request may close these issues.

Add CWE support in all importers
3 participants
@ambuj-1211 @ziadhany @TG1999