-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OCI labels to dockerfile #3977
base: develop
Are you sure you want to change the base?
Conversation
de1ee4e
to
d5c53dc
Compare
@pombredanne @AyanSinhaMahapatra kindly review this PR. THANK YOU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VarshaUN thanks!
There are probably a few more fields we can add from https://github.com/opencontainers/image-spec/blob/main/annotations.md?plain=1#L22
Btw note that #3561 was for adding support to parse these information into package data from files we scan (So this does not fix the issue linked in your PR, I edited your PR comment).
Adding these fields to our dockerfile is also nice to have, thanks!
Signed-off-by: Varsha U N <[email protected]>
Signed-off-by: Varsha U N <[email protected]>
cdd51cf
to
c78de39
Compare
Sure @AyanSinhaMahapatra . I have added some which I think are not repeated.
OK I got this. Thanks for the clarification. I will look into it. |
@AyanSinhaMahapatra please review this. Thank you |
Reference: #3561
Tasks
Run tests locally to check for errors.
Thanks!
Signed-off-by: Varsha U N [email protected]