Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OCI labels to dockerfile #3977

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

VarshaUN
Copy link

@VarshaUN VarshaUN commented Nov 9, 2024

Reference: #3561

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass --
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Thanks!

Signed-off-by: Varsha U N [email protected]

@VarshaUN VarshaUN force-pushed the add-OCi-label-Dockerfile branch from de1ee4e to d5c53dc Compare November 9, 2024 02:55
@VarshaUN
Copy link
Author

VarshaUN commented Nov 9, 2024

@pombredanne @AyanSinhaMahapatra kindly review this PR. THANK YOU

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VarshaUN thanks!

There are probably a few more fields we can add from https://github.com/opencontainers/image-spec/blob/main/annotations.md?plain=1#L22

Btw note that #3561 was for adding support to parse these information into package data from files we scan (So this does not fix the issue linked in your PR, I edited your PR comment).

Adding these fields to our dockerfile is also nice to have, thanks!

@VarshaUN VarshaUN force-pushed the add-OCi-label-Dockerfile branch from cdd51cf to c78de39 Compare November 14, 2024 16:33
@VarshaUN
Copy link
Author

There are probably a few more fields we can add from https://github.com/opencontainers/image-spec/blob/main/annotations.md?plain=1#L22

Sure @AyanSinhaMahapatra . I have added some which I think are not repeated.

Btw note that #3561 was for adding support to parse these information into package data from files we scan (So this does not fix the issue linked in your PR, I edited your PR comment).

OK I got this. Thanks for the clarification. I will look into it.

@VarshaUN
Copy link
Author

@AyanSinhaMahapatra please review this. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants