-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect go binary packages #3894
Conversation
Reference: aboutcode-org/go-inspector#15 Reference: aboutcode-org/go-inspector#13 Signed-off-by: Philippe Ombredanne <[email protected]>
2217d75
to
434322f
Compare
Signed-off-by: Philippe Ombredanne <[email protected]>
434322f
to
038eb03
Compare
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
@AyanSinhaMahapatra ready for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @pombredanne
Can be merged with a minor nit resolved.
I'm getting a:
On running Edit: seems to be a fluke, not happening anymore |
I think https://github.com/aboutcode-org/go-inspector/blob/main/src/go_inspector/binary.py#L482 should be in packagedcode here? Or do we need #3761 to be merged before that? |
Signed-off-by: Philippe Ombredanne <[email protected]> Co-authored-by: Ayan Sinha Mahapatra <[email protected]>
Thanks @pombredanne , merging! |
This PR add support to scan Go binaries for their embedded packages. This is the ScanCode side.
The Go inspector PR is at
Tasks
Run tests locally to check for errors.