-
-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alpine url bug fix and AGPL License version issue #3744
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: 404-geek <[email protected]>
Signed-off-by: 404-geek <[email protected]>
@404-geek Thanks... can you check the test failures? Also in the future it is usually best to avoid mixing two unrelated changes in the same PR... here the license detection issue is not related to anything about alpine VCS URL handling, AFAIK ;) |
…ression in pdfminer nexB#3740 Signed-off-by: 404-geek <[email protected]>
Signed-off-by: 404-geek <[email protected]>
Signed-off-by: 404-geek <[email protected]>
Sure @pombredanne will take care of not keeping 2 issues in same PR in the future I have resolved all the test issues. Can you please check once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks++ @404-geek , we are mostly there.
@@ -1,5 +1,5 @@ | |||
--- | |||
license_expression: agpl-3.0-plus OR commercial-license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the change is correct note that the rule filenames reflect the license-expression of the rule and a change in the license-expression needs to happen like this:
- Deprecate the current rule using the
is_deprecated
attribute - Reindex the licenses with
scancode-reindex-licenses
(This will remove the deprecated rule from the index so you can add a new one, otherwise two rules with the same text cannot exist in the index) - Add a new rule for just
agpl-3.0-plus
and add notes about the origin, that this was previously the src/agpl-3.0-plus_or_commercial-license_4.RULE
rule. Add the issue reference in the commit. (You can paste the rule content atetc/scripts/licenses/buildrules-template.txt
and then runpython etc/scripts/licenses/buildrules.py etc/scripts/licenses/buildrules-template.txt
in an activated virtualenv, and this will create the rule automatically, with the appropriate filename)
@404-geek gentle ping, we need a small update here. |
@404-geek ping :) I would like to merge this soon enough! |
No description provided.