remove unwanted files dependencies #176
Conversation
Signed-off-by: Pratik Dey <[email protected]>
Signed-off-by: Pratik Dey <[email protected]>
tests/test_deltacode.py
Outdated
| @@ -422,6 +422,7 @@ def test_Delta_create_object_removed(self): | |||
| assert 'removed' in delta.factors | |||
| assert delta.score == 0 | |||
|
|
|||
| @pytest.mark.xfail(reason='Tests no longer required having None paths') | |||
There was a problem hiding this comment.
Keeping it xfail for now as these test it requires File models and since it is just one line in the File I thought it would be quite trivial to mae a separate .json object to scan it
There was a problem hiding this comment.
Since we are removing the File object, I think we can just remove these tests, right?
| class ScanException(Exception): | ||
| """ | ||
| Named exception for JSON file (1) containing no 'scancode_version' | ||
| attribute, (2) containing old version of ScanCode, or (3) containing no | ||
| 'scancode_options'/'--info' attribute. | ||
| """ | ||
| pass |
There was a problem hiding this comment.
Actually they are inbuilt in VirtualCodebase so i felt they might not be needed
tests/test_deltacode.py
Outdated
| @@ -422,6 +422,7 @@ def test_Delta_create_object_removed(self): | |||
| assert 'removed' in delta.factors | |||
| assert delta.score == 0 | |||
|
|
|||
| @pytest.mark.xfail(reason='Tests no longer required having None paths') | |||
There was a problem hiding this comment.
Since we are removing the File object, I think we can just remove these tests, right?
src/deltacode/cli.py
Outdated
| @@ -48,7 +48,7 @@ def write_json(deltacode, outfile, all_delta_types=False): | |||
| # ('old_scan_options', deltacode.old_scan_options), | |||
| ('deltacode_options', deltacode.options), | |||
| ('deltacode_version', __version__), | |||
| ('deltacode_errors', collect_errors(deltacode)), | |||
| ('deltacode_errors', []), | |||
Signed-off-by: Pratik Dey <[email protected]>
Signed-off-by: Pratik Dey <[email protected]>
|
Updated! |
| self._populate(new_path, old_path) | ||
|
|
||
| self.new_scan_options = [] | ||
| self.old_scan_options = [] |
There was a problem hiding this comment.
I forget where we stand on this, but if the VirtualCodebase objects contain this information, I do not see the value of our DeltaCode object containing it as well.
There was a problem hiding this comment.
VirtualCodebase is actually having all the resources but Delta objects will only contains only the respective deltas
remove unwanted files dependencies
Signed-off-by: Pratik Dey [email protected]