lispy.el (lispy-unbind-variable): Call iedit-update-occurrences #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes abo-abo#576 on Emacs 27.2
The old code was messing up in case of `coalton-toplevel'.
It doesn't work the same way as before, since `ivy-read' is used to select the value. However, `unread-command-events' don't seem to work in batch mode.
Print which variable will be set to what.
In Python 3.10, there's no collections.KeysView
Ensures that swiper and ivy only load on demand. Fixes abo-abo#616
* lispy.el (lispy--action-jump): Remove `with-ivy-window', it's not needed. Fixes abo-abo#616
* le-clojure.el (lispy-cider-jack-in-dependencies): Default to nil. Fixes abo-abo#615
When using the code, we relied on `top_level' for setting global bindings. This no longer worked when using `pytest' for testing. I like this change because it also is a step towards reflecting how Python uses frames for eval, instead of just shadowing everything in top level.
…use_in_expr" env flag
* Decision
Given this context:
#+begin_src python
xs = ["1", "2", "3"]
x = "2"
#+end_src
~e~ on src_python{x in xs} should print "True"
~p~ on src_python{x in xs} should give the option to set =x= to become one of the values of =xs=.
* Rationale
src_python{x in xs} is a very common pattern in Python that has two meanings:
1. is the item in the collection
2. iterate over the collection
The split between the two meanings is 50/50, to say roughly. No one meaning prevails over
another.
The default in Python REPL is to choose meaning-1. Previously, lispy would give ~e~
meaning-2. In this way, both bases were covered. If meaning-1 was desired, copying the
code, switching to the REPL and pasting it directly would "work".
This is, however, inconvenient. So we introduce another binding ~p~ to mean "alternative
eval", just like we already have in Elisp and Clojure. And have ~e~ do the usual meaning-1
eval in this case, while ~p~ will do the meaning-2 eval.
This may happen when trying to load on a remote system that has nothing installed.
So that random Python output doesn't mess up our `read'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576 on Emacs 27.2