Improve test server error handling #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawrence-forooghian
force-pushed
the
improve-test-server-error-handling
branch
from
ca5f49e to
700753b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1824/bundle-report
The following errors were just being absorbed, making them hard to notice and debug: - app.listen throwing a synchronous error (e.g. in the case where you specify -1 as a port number) - app.listen throwing an asynchronous error (e.g. in the EADDRINUSE case)
lawrence-forooghian
force-pushed
the
improve-test-server-error-handling
branch
from
700753b to
3ce7032
Compare
lawrence-forooghian
changed the base branch from
main
to
upgrade-prettier-and-run-on-everything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few quality of life improvements. See commit messages for more details.