Merge main into integration/v2
#1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade Playwright to 1.39.0
Enable 'derived' options in 'useChannel' hook
The import paths here only worked before by accident - tsc would compile then to `from '../../../ably'` which in most cases would resolve to `node_modules/ably` however in certain environments (pnpm) this would not be the case and therefore the types would not be imported correctly. I've updated the tsconfig compilerOptions.paths field so that these are resolved correctly for development, and when consumed as a library these will just import directly from the 'ably' module.
fix: use 'ably' as import path from react-hooks
Release 1.2.48
ci: check if the types are wrong
It is meant to return `null` (per TG4 and our documentation comments), but was returning `undefined`. Resolves #1542.
[SDK-3990] Fix `PaginatedResult.next()` behaviour when no next page
github-actions
bot
temporarily deployed
to
staging/pull/1544/features
github-actions
bot
temporarily deployed
to
staging/pull/1544/typedoc
lawrence-forooghian
force-pushed
the
2023-12-11-merge-main-into-v2
branch
from
694babc to
105d1cf
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1544/features
github-actions
bot
temporarily deployed
to
staging/pull/1544/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1544/typedoc
lawrence-forooghian
force-pushed
the
2023-12-11-merge-main-into-v2
branch
from
105d1cf to
5a43ef6
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1544/features
github-actions
bot
temporarily deployed
to
staging/pull/1544/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1544/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1544/features
github-actions
bot
temporarily deployed
to
staging/pull/1544/bundle-report
VeskeR
requested changes
Jan 10, 2024
There was a problem hiding this comment.
There seems to be couple more merge conflicts with integration/v2 due to changes in react-hooks.
Other than that, LGTM! Can merge once comments are resolved.
Temporary fix for attw error will work for now. Will fix it for good in #1546.
…or-reauth Use correct request headers in `Resource` after re-auth
lawrence-forooghian
force-pushed
the
2023-12-11-merge-main-into-v2
branch
from
6138243 to
d36d97b
Compare
VeskeR
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve worked around the
attwerror that this introduces because I wasn’t able to solve it quickly; have created #1546 for doing so.