[SDK-3943] Add some regression testing for bundle size and included files #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
478298d to
d176d34
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
29f876f to
bd48dc8
Compare
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
d176d34 to
b8b57ee
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
bd48dc8 to
954d6e7
Compare
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
b8b57ee to
1ed2065
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
954d6e7 to
b04f03f
Compare
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
1ed2065 to
9e0f343
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
9e0f343 to
b5d8fe5
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
owenpearson
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Looks great! I'm a big fan of the test to ensure we don't accidentally re-include modules in the minimal client. The latter test I think having a static threshold is a bit arbitrary and maybe we could consider something like snapshot testing in future but it's better than nothing so happy to approve anyway
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
b5d8fe5 to
beb1038
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
owenpearson
approved these changes
Nov 27, 2023
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
b04f03f to
3b0a73e
Compare
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
beb1038 to
f8c9f3b
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
3b0a73e to
fd7712d
Compare
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
f8c9f3b to
61b87ed
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1507/features
github-actions
bot
temporarily deployed
to
staging/pull/1507/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1507/typedoc
lawrence-forooghian
force-pushed
the
exclude-PresenceMessage-from-base-realtime
branch
from
fd7712d to
10bac3c
Compare
Want to use `await` in an upcoming commit.
To give us further confidence that something unexpected won’t sneak in. This just automates a rather crude process that I’ve been performing manually from time to time — tweak the moduleReport script to spit out source file + source map, then run source-map-explorer on the output and look at which files are making a significant contribution to the bundle size. Part of #1497.
Another protection against regressions in bundle size. Resolves #1497.
lawrence-forooghian
force-pushed
the
1497-regression-testing-bundle
branch
from
61b87ed to
3f12e9c
Compare
Base automatically changed from
exclude-PresenceMessage-from-base-realtime
to
integration/v2
November 27, 2023 19:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on top of #1505; please review that one first.
This enhances the
modulereportscript, which gets run in CI, to do the following:BaseRealtimebundle size (against a hardcoded allow list)The idea being to have some safeguards against accidental regressions in bundle size.
Resolves #1497.