Skip to content

Commit

Permalink
build: dont check submodules to build module
Browse files Browse the repository at this point in the history
The only git submodule we need is ably-common, and this is only used as part of testing to create
test apps. We don't use it when building (despite it being a build check).

This check during build prevents other SDKs from depending on a branch of ably-js, as it doesn't have
the submodules, and can't init them.

This change therefore removes the submodules check when building the library, allowing SDKs to depend on branch
versions, if they want to.
  • Loading branch information
AndyTWF committed Nov 27, 2024
1 parent 18a2559 commit 8248411
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ module.exports = function (grunt) {
});
});

grunt.registerTask('build', ['checkGitSubmodules', 'webpack:all', 'build:browser', 'build:node', 'build:push']);
grunt.registerTask('build', ['webpack:all', 'build:browser', 'build:node', 'build:push']);

grunt.registerTask('all', ['build', 'requirejs']);

Expand Down

0 comments on commit 8248411

Please sign in to comment.