-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/connection: dont cancel transient disconnect timer with connecting status #404
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File Coverage
|
95d9b03
to
ee4dff3
Compare
ee4dff3
to
f58e57e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
f58e57e
to
0a90909
Compare
…ng status At the moment, if a connecting status is received during a transient disconnect timer, we cancel the timer. This isn't really ideal - as it defeats the point of a transient disconnect timeout. Equally, we suppress the error that caused the state in the first place. This change: - Will only cancel the transient disconnect timeout on a state that isn't connecting. - When the transient disconnect timeout timer expires, it will pass the *current* status, but with the error from the original state change.
0a90909
to
363742a
Compare
Description
At the moment, if a connecting status is received during a transient disconnect timer, we cancel the timer.
This isn't really ideal - as it defeats the point of a transient disconnect timeout. Equally, we suppress the error that caused the state in the first place.
This change:
Checklist
Testing Instructions (Optional)
N/A