Support Svelte@4 #208
Merged
Support Svelte@4 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phocks
approved these changes
Jun 27, 2023
|
@AshKyd since you're looking at aunty things — it might be worth picking some of the commits from this. The svelte 4 upgrade was the only part of this that had some sticking points, iirc and I shouldn't have bundled them into one PR. |
|
Hey @AshKyd I'm just going to merge this and we can work out how to get these tests passing next. I've tested generate and build in new projects and they all go fine when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim here was to support Svelte 4, but a few other dependencies got a bump too.
It's technically a breaking change, so will result in a major version bump.