Tables should be passed through instead of being stripped out #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, links inside tables need to be HTML otherwise they will not be recognized as links.
|
Can we make this an option, default off? I don't think most users expect to get big chunks of HTML in their output. |
|
Sure, if you want to turn that into an option, that's not a bad idea. I think you're right that people don't expect lots of HTML, but at the same time, stripping out the tables and just outputting broken formatting is not ideal either. So, personally I'm not sure which one should be the default, but in my use case, I certainly didn't want to lose my tables after converting from HTML to Markdown. |
|
Wouldn't it be more useful to convert to Markdown tables? Issue #50 seems to be much more interesting than this. |
pombredanne
pushed a commit
to pombredanne/html2text
that referenced
this pull request
Oct 10, 2015
<a> tags with no text or <img> tags no longer discarded. Thanks @mgontav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, links inside tables need to be HTML otherwise they
will not be recognized as links.