Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: quality: restructure project to better align with the best practices #55

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

aakso
Copy link
Owner

@aakso aakso commented Oct 29, 2023

  • make most of the packages internal. The packages are currently not imported by anyone and as we are <1.0, this is a fair game.
  • move main packages to cmd/{binaryName}
  • rename client package to ui which better describes the functionality. Currently, the project provides no actual API client to consume.

@aakso aakso requested a review from scop October 29, 2023 09:07
…actices

* make most of the packages internal. The packages are currently not
  imported by anyone and as we are <1.0, this is a fair game.
* move main packages to `cmd/{binaryName}`
* rename `client` package to `ui` which better describes the functionality.
  Currently, the project provides no actual API client to consume.
@aakso aakso force-pushed the chore/restructure-project branch from bac85a3 to a0ae40e Compare October 29, 2023 09:18
@aakso aakso self-assigned this Oct 29, 2023
Copy link
Collaborator

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aakso aakso merged commit 13e30d2 into master Oct 30, 2023
3 checks passed
@aakso aakso deleted the chore/restructure-project branch October 30, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants