chore(engine): Migrate To Alloy #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
added
A-engine
refcell
changed the title
ncitron
approved these changes
May 1, 2024
src/l1/chain_watcher.rs
Outdated
| .map(|log| UserDeposited::try_from(log).unwrap()) | ||
| .collect::<Vec<UserDeposited>>(); | ||
|
|
||
| // TODO: Optimize this to batch requests. |
There was a problem hiding this comment.
Just want to note that this should be a high priority. Perf was pretty significantly effected by not batching these when I was first testing it out.
There was a problem hiding this comment.
I was fortunately mistaken here - the alloy_rpc_types::Log does contain the hydrated block information, which is the object returned by the provider's get_logs method. I had confused this with the alloy_primitives::Log type. Fixing it right now and will push the fix :)
refcell
force-pushed
the
refcell/chore/engine-alloy-port
branch
from
ca41e5a to
783b18f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
This should be merged after #240
Migrates
enginemodule types to Alloy.Metadata
Fixes #232