Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): Migrate more types to Alloy #226

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 29, 2024

Description

Migrates more types in the config module to alloy and updates a bunch of references to these variables.

Fixes #227

@refcell refcell requested a review from ncitron April 29, 2024 21:26
@refcell refcell force-pushed the refcell/alloy-round-2 branch 2 times, most recently from 3803e1d to 77563a4 Compare April 29, 2024 21:31
@refcell refcell self-assigned this Apr 29, 2024
@refcell refcell added M-port Meta: Ports code to new implementations A-config Area: Magi configuration changes labels Apr 29, 2024
fix: migrate config to alloy

fix: more alloy migration

fix: more alloy migration

fix: more alloy migration
@refcell refcell force-pushed the refcell/alloy-round-2 branch from 06e40ea to f540b16 Compare April 29, 2024 21:40
Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncitron ncitron merged commit 9c3f6c8 into alloy Apr 29, 2024
5 checks passed
@ncitron ncitron deleted the refcell/alloy-round-2 branch April 29, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config Area: Magi configuration changes M-port Meta: Ports code to new implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants