Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common): Migrate AttributesDeposited to Alloy Types #225

Merged
merged 4 commits into from
Apr 29, 2024
Merged

chore(common): Migrate AttributesDeposited to Alloy Types #225

merged 4 commits into from
Apr 29, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Apr 29, 2024 •
edited
Loading

Description

Kicks off the alloy type migration by adding alloy_primitives to the manifest and migrates AttributesDepositedCall to use alloy types internally.

Temporary type conversions are done through raw big endian type representation.

Metadata

Fixes #225

@refcell refcell requested a review from ncitron April 29, 2024 18:24
@refcell refcell self-assigned this Apr 29, 2024
@refcell refcell added F-deps Flag: Dependency changes A-common Area: Common types M-port Meta: Ports code to new implementations labels Apr 29, 2024
ncitron
ncitron reviewed Apr 29, 2024
View reviewed changes
src/driver/types.rs Outdated Show resolved Hide resolved
@refcell refcell requested a review from ncitron April 29, 2024 19:52
@refcell
Copy link
Collaborator Author

refcell commented Apr 29, 2024

As a sidenote, all these type conversion like .to_vec() will go away once everything is migrated to alloy types :)

ncitron
ncitron approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 64986af into alloy Apr 29, 2024
5 checks passed
@ncitron ncitron deleted the refcell/alloy-migration branch April 29, 2024 19:58
@refcell refcell mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncitron ncitron ncitron approved these changes

Assignees

@refcell refcell

Labels
A-common Area: Common types F-deps Flag: Dependency changes M-port Meta: Ports code to new implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @ncitron