Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add full documentation to all crates #210

Merged
merged 10 commits into from
Feb 12, 2024

Conversation

zilayo
Copy link
Contributor

@zilayo zilayo commented Feb 9, 2024

This PR aims to provide full basic documentation coverage for Magi.

Comments have been added to all public members to generate documentation, as well as private members to help with code navigation.

Some sections were already well documented so these have been left as is.

No logic has been updated - this is solely a documentation update.

Hopefully this will be useful to help newcomers become familiar with the codebase.

Most comments are minimal so can definitely be expanded on in the future.

Also added a clippy rule to warn about missing documentation for public members.

image

@zilayo
Copy link
Contributor Author

zilayo commented Feb 9, 2024

  • obligatory "FiX tYpOs" commit

Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is amazing! CI is failing but that seems unrelated to this PR.

@ncitron ncitron merged commit 82e2c51 into a16z:master Feb 12, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants