Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ecotone hardfork support #204

Merged
merged 23 commits into from
Mar 11, 2024
Merged

feat: Ecotone hardfork support #204

merged 23 commits into from
Mar 11, 2024

Conversation

merklefruit
Copy link
Contributor

@merklefruit merklefruit commented Feb 2, 2024 •
edited
Loading

Closes #200.

Tasks

  •  Add blob data source support via L1 beacon node
  • Decode blobs
  • Adapt batcher transactions to both calldata and blob DA sources
  • Add Ecotone L1 block info fields
  • Parse new setL1BlockValuesEcotone params
  • Add parent beacon block root
  • Add blocks/v3 p2p gossip topic
  • Add relevant tests
  • synced an OP Sepolia node to tip

@merklefruit merklefruit force-pushed the 02-02-feat_blob_fetcher branch from da30a40 to abd1e09 Compare February 18, 2024 15:44
@merklefruit merklefruit force-pushed the 02-02-feat_blob_fetcher branch from 800b2f4 to 46a71eb Compare February 25, 2024 18:06
@merklefruit merklefruit changed the title wip: Ecotone support feat: Ecotone hardfork support Feb 25, 2024
@merklefruit merklefruit marked this pull request as ready for review February 25, 2024 18:20
merklefruit added 19 commits March 2, 2024 11:04
@merklefruit merklefruit force-pushed the 02-02-feat_blob_fetcher branch from d70c3d8 to b99f408 Compare March 2, 2024 10:06
ncitron
ncitron reviewed Mar 9, 2024
View reviewed changes
Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me. Just left a few questions and comments.

src/l1/blob_fetcher.rs Outdated Show resolved Hide resolved
docker/docker-compose.yml Outdated Show resolved Hide resolved
src/derive/stages/attributes.rs Outdated Show resolved Hide resolved
src/driver/types.rs Show resolved Hide resolved
src/l1/blob_fetcher.rs Outdated Show resolved Hide resolved
@merklefruit
Copy link
Contributor Author

@ncitron I've moved the get_batcher_transactions functionality to the chain watcher which makes a lot more sense.

ncitron
ncitron approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 84079c0 into a16z:master Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncitron ncitron ncitron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ecotone Tracker
2 participants
@merklefruit @ncitron