-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plonk: Add solidity verifier #1249
Open
georgwiese
wants to merge
25
commits into
Zokrates:add-bellman-plonk-backend
Choose a base branch
from
georgwiese:plonk-add-verifier
base: add-bellman-plonk-backend
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Plonk: Add solidity verifier #1249
georgwiese
wants to merge
25
commits into
Zokrates:add-bellman-plonk-backend
from
georgwiese:plonk-add-verifier
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwiese
changed the title
[WIP] Plonk add verifier
[WIP] Plonk: Add solidity verifier
Nov 30, 2022
georgwiese
commented
Nov 30, 2022
georgwiese
changed the title
[WIP] Plonk: Add solidity verifier
Plonk: Add solidity verifier
Nov 30, 2022
Schaeff
reviewed
Dec 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things! 👍
We can fix CI on the target branch I think
zokrates_proof_systems/src/solidity_renderers/plonk_solidity_renderer.rs
Outdated
Show resolved
Hide resolved
zokrates_proof_systems/src/solidity_renderers/plonk_solidity_renderer.rs
Outdated
Show resolved
Hide resolved
Thanks for the review! The integration test fails now, as it did before this PR. I'll try to fix tests in the next PR, which is about splitting the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are:
zokrates_bellman
:plonk.rs
:serialize_vk()
now pre-computesomega
. This is redundant, but needed to render the solidity verifier.zokrates_cli
:tests/integration.rs
: Adjusted thetest_compile_and_witness_dir
test to run only for plonk. It should pass now, testing the full pipeline, including proof verification in solidity.zokrates_proof_systems
:solidity_renderer.rs
, which is an adjusted version from this code from matter-labs.georgwiese:plonk-add-verifier
.PlonkVerifier.sol
: The Plonk solidity template, copied and adjusted from this code from matter-labs.scheme/plonk.rs
: This file moved to thezokrates_bellman
create, as mentioned above.to_token.rs
: Some refactoringsTo test, run: