Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): Refactor getrawtransaction & RPC error handling #9049

Merged
merged 53 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from 47 commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
6a27482
clean-up: simplify the def of `MapServerError`
upbqdn Sep 5, 2024
4827028
Use `HexData` instead of `String` for TXIDs
upbqdn Oct 21, 2024
1dcd49a
Remove a redundant test
upbqdn Oct 21, 2024
1cfe1cc
Adjust tests for using `HexData`
upbqdn Oct 21, 2024
9aa561d
Make `height` and `confirmations` optional
upbqdn Nov 12, 2024
a973aab
Use legacy error codes
upbqdn Nov 13, 2024
7ccac98
fmt
upbqdn Nov 13, 2024
08234b7
Remove unneeded error codes
upbqdn Nov 13, 2024
3247923
Remove `zebra-rpc/src/constants.rs`
upbqdn Nov 13, 2024
f6da233
Rename `MapServerError` to `MapError`
upbqdn Nov 13, 2024
4b88252
Rename `OkOrServerError` to `OkOrError`
upbqdn Nov 13, 2024
2c7aa71
Allow specifying error codes when mapping errors
upbqdn Nov 13, 2024
91ed312
Allow setting error codes when mapping options
upbqdn Nov 13, 2024
943a815
Use the right error code for `getrawtransaction`
upbqdn Nov 14, 2024
c3d1e83
fmt
upbqdn Nov 14, 2024
415b919
Add docs for the error conversion traits
upbqdn Nov 14, 2024
91361d8
Refactor the error handling for `getblock`
upbqdn Nov 14, 2024
fb40ae0
Refactor error handling in `sendrawtransaction`
upbqdn Nov 15, 2024
c23501a
Refactor the error handling for `getblock`
upbqdn Nov 15, 2024
03e9b25
Update the error handling for `getrawtransaction`
upbqdn Nov 15, 2024
0d1d0c8
Refactor error handling for `z_gettreestate`
upbqdn Nov 15, 2024
57325f0
Refactor the error handling for address parsing
upbqdn Nov 15, 2024
c29e410
Refactor the error handling for getrawtransaction
upbqdn Nov 16, 2024
db48268
Merge branch 'main' into fix-getrawtx
upbqdn Nov 18, 2024
7777f3d
Update `z_gettreestate` snapshots
upbqdn Nov 18, 2024
a20b5f1
Cosmetics
upbqdn Nov 18, 2024
2983b14
Merge branch 'main' into fix-getrawtx
upbqdn Nov 19, 2024
5696e0b
Refactor error handling in `getblock`
upbqdn Nov 19, 2024
71186b5
Refactor error handling in `getblockheader`
upbqdn Nov 19, 2024
acac270
Merge branch 'main' into fix-getrawtx
upbqdn Nov 19, 2024
7fef8bf
Simplify `getrawtransaction`
upbqdn Nov 20, 2024
821b8b9
Check errors for `getrawtransaction`
upbqdn Nov 20, 2024
7c38903
fmt
upbqdn Nov 20, 2024
a654e39
Simplify proptests
upbqdn Nov 20, 2024
3a305c2
Merge branch 'main' into fix-getrawtx
upbqdn Nov 20, 2024
f1fb94f
Fix unit tests for `getaddresstxids`
upbqdn Nov 21, 2024
088ba62
Fix unit tests for `getaddressutxos`
upbqdn Nov 21, 2024
110f4b5
fix docs
upbqdn Nov 21, 2024
cdc21da
Update snapshots for `getrawtransaction`
upbqdn Nov 21, 2024
475dbc9
Update zebra-rpc/src/server/error.rs
upbqdn Dec 9, 2024
9f778e4
Merge branch 'main' into fix-getrawtx
upbqdn Dec 10, 2024
bdb8372
Use `transaction::Hash` instead of `HexData`
upbqdn Dec 10, 2024
ed69359
Simplify error handling
upbqdn Dec 10, 2024
37d1a44
Update zebra-rpc/src/server/error.rs
upbqdn Dec 10, 2024
2c342f7
Move a note on performance
upbqdn Dec 10, 2024
74fe0f4
Fix a typo
upbqdn Dec 10, 2024
7eb3e95
Merge branch 'main' into fix-getrawtx
mergify[bot] Dec 11, 2024
6e1e011
Use `String` instead of `transaction::Hash`
upbqdn Dec 12, 2024
ae6000f
Adjust and add proptests
upbqdn Dec 12, 2024
b54dd79
Merge branch 'main' into fix-getrawtx
upbqdn Dec 12, 2024
7db6ff6
Reintroduce snapshots for invalid TXIDs
upbqdn Dec 12, 2024
bc32ddb
Merge branch 'fix-getrawtx' of github.com:ZcashFoundation/zebra into …
upbqdn Dec 12, 2024
c9088f8
Don't derive `Serialize` & `Deserialize` for txids
upbqdn Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions zebra-rpc/src/constants.rs

This file was deleted.

1 change: 0 additions & 1 deletion zebra-rpc/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#![doc(html_root_url = "https://docs.rs/zebra_rpc")]

pub mod config;
pub mod constants;
pub mod methods;
pub mod queue;
pub mod server;
Expand Down
Loading
Loading