Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup(clippy): Resolve new nightly clippy and rustc lints #7860

Merged
merged 1 commit into from
Oct 27, 2023
Merged

cleanup(clippy): Resolve new nightly clippy and rustc lints #7860

merged 1 commit into from
Oct 27, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

New clippy lints were added to nightly Rust this week, it's easiest to fix them gradually as they appear.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-Optional ✨ A-diagnostics Area: Diagnosing issues or monitoring performance C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 27, 2023
@teor2345 teor2345 self-assigned this Oct 27, 2023
@teor2345 teor2345 requested review from a team as code owners October 27, 2023 05:05
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 27, 2023 05:05
arya2
arya2 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

mergify bot added a commit that referenced this pull request Oct 27, 2023
@mergify
Merge of #7860
c33ac08
@mergify mergify bot mentioned this pull request Oct 27, 2023
Closed
@mergify mergify bot merged commit 7e7f989 into main Oct 27, 2023
103 checks passed
@mergify mergify bot deleted the clippy-20231027 branch October 27, 2023 19:35
@teor2345 teor2345 mentioned this pull request Nov 5, 2023
Merged
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/network-reviewers

Assignees

@teor2345 teor2345

Labels
A-diagnostics Area: Diagnosing issues or monitoring performance A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @arya2