-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove(cmd): Remove zebrad download
command, because it no longer does anything
#7819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
Area: Updates to Rust code
P-Medium ⚡
C-removal
Category: Features that have been removed
labels
Oct 25, 2023
github-actions
bot
added
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
labels
Oct 25, 2023
github-actions
bot
added
the
extra-reviews
This PR needs at least 2 reviews to merge
label
Oct 25, 2023
teor2345
added
A-cli
Area: Command-line interfaces and processes
A-devops
Area: Pipelines, CI/CD and Dockerfiles
and removed
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
A-rust
Area: Updates to Rust code
labels
Oct 25, 2023
upbqdn
previously approved these changes
Oct 25, 2023
Co-authored-by: Marek <[email protected]>
github-actions
bot
added
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
labels
Oct 25, 2023
Failed due to #7796 |
upbqdn
approved these changes
Oct 25, 2023
6 tasks
I have disabled the coverage job and branch protection rule due to #7828, its failure will disappear the next time this PR's branch is updated. |
@Mergifyio refresh |
✅ Pull request refreshed |
teor2345
removed
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
labels
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now the parameters are built into the binary, we can remove the
zebrad download
command and the Dockerfiles and CI workflows that use it.This significantly reduces the size of Docker images, by about 600 MB.
Close #7811
Solution
zebrad download
zcash-params/Dockerfile
zebrad download
removalReview
This is a user-visible cleanup, let's merge it before the release next week, because the parameter change is already merged.
Reviewer Checklist