Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Add missing timeouts to CI and CD tests #7730

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 11, 2023

Motivation

If some CI Docker tests hang, they won't time out for 6 hours. But they never usually take more than 90 minutes.

This means it can be a long time before we see the timeout, which slows down PR fixes (and also other PRs can't use those runners).

Since some runners are custom runners, this also increases our costs.

Depends-On: #7616

Solution

Add 90 minute timeouts to these jobs.

Review

This is a low priority.

@gustavovalverde did you want it to wait until the other refactors merge?

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ I-cost Zebra infrastructure costs C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 11, 2023
@teor2345 teor2345 self-assigned this Oct 11, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 11, 2023 20:35
@teor2345 teor2345 requested review from arya2 and removed request for a team October 11, 2023 20:35
@gustavovalverde
Copy link
Member

@gustavovalverde did you want it to wait until the other refactors merge?

Yes, I've added a Depends-On anyways so it can be approved and not merged

arya2
arya2 previously approved these changes Oct 11, 2023
@upbqdn upbqdn added the do-not-merge Tells Mergify not to merge this PR label Oct 13, 2023
@teor2345 teor2345 removed the do-not-merge Tells Mergify not to merge this PR label Oct 16, 2023
arya2
arya2 previously approved these changes Oct 18, 2023
@teor2345 teor2345 changed the base branch from main to refactor-workflows October 18, 2023 04:24
@teor2345 teor2345 changed the title fix(ci): Add missing timeouts to continous-integration-docker.yml fix(ci): Add missing timeouts to CI and CD tests Oct 18, 2023
Base automatically changed from refactor-workflows to main October 18, 2023 06:16
@mergify mergify bot dismissed arya2’s stale review October 18, 2023 06:16

The base branch was changed.

@mergify mergify bot requested a review from a team as a code owner October 18, 2023 06:16
mergify bot added a commit that referenced this pull request Oct 18, 2023
@gustavovalverde
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Oct 19, 2023
mergify bot added a commit that referenced this pull request Oct 19, 2023
mergify bot added a commit that referenced this pull request Oct 19, 2023
mergify bot added a commit that referenced this pull request Oct 19, 2023
@mergify mergify bot merged commit 2f14efa into main Oct 19, 2023
95 checks passed
@mergify mergify bot deleted the ci-docker-timeouts branch October 19, 2023 12:30
@teor2345 teor2345 mentioned this pull request Nov 5, 2023
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-cost Zebra infrastructure costs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants